Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
11 Apr 2015

Still a work in progress, this branch will have the web hooks updated to insert data to the database via model classes versus the table classes.

avatar mbabker mbabker - open - 11 Apr 2015
avatar mbabker mbabker - change - 12 Apr 2015
Title
[WIP] Use models in web hooks
Use models in web hooks
avatar mbabker
mbabker - comment - 12 Apr 2015

OK, I think this should be ready for review now.

avatar mbabker mbabker - change - 12 Apr 2015
Title
[WIP] Use models in web hooks
Use models in web hooks
avatar b2z
b2z - comment - 16 Apr 2015

@mbabker looks good, but I wonder should we process the milestones in the hooks like we do it for labels?

avatar mbabker
mbabker - comment - 16 Apr 2015

Probably. But that'd be a separate PR I think to add that functionality. This just cleans things up a bit so that the hooks are validating data with the same rules as the UI input.

avatar b2z
b2z - comment - 16 Apr 2015

Ok then. Let's merge and watch for it :)

avatar b2z b2z - change - 16 Apr 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-04-16 17:54:32
avatar b2z b2z - close - 16 Apr 2015
avatar b2z b2z - reference | 54964c0 - 16 Apr 15
avatar b2z b2z - merge - 16 Apr 2015
avatar b2z b2z - close - 16 Apr 2015
avatar b2z b2z - head_ref_deleted - 16 Apr 2015

Add a Comment

Login with GitHub to post a comment