Success

User tests: Successful: Unsuccessful:

avatar b2z
b2z
2 Mar 2015

See #582 for reference. Live demo is available on my test server.

avatar b2z b2z - open - 2 Mar 2015
avatar mbabker
mbabker - comment - 2 Mar 2015

Looks good. One comment: Any way to use white text for the input field instead of it being black? It's a little difficult to read on the menu bar.

avatar brianteeman
brianteeman - comment - 2 Mar 2015

Can you make the entire text "Select language" clickable - not just the
very small arrow

On 2 March 2015 at 19:17, Michael Babker notifications@github.com wrote:

Looks good. One comment: Any way to use white text for the input field
instead of it being black? It's a little difficult to read on the menu bar.


Reply to this email directly or view it on GitHub
#628 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar b2z
b2z - comment - 2 Mar 2015

Looks good. One comment: Any way to use white text for the input field instead of it being black? It's a little difficult to read on the menu bar.

I tried, but can not find proper CSS style to make it. We need a CSS expert here :)

Can you make the entire text "Select language" clickable - not just the
very small arrow

Will try

avatar b2z
b2z - comment - 2 Mar 2015

@brianteeman just tried to make it, but with no luck :( If I am wrapping the text in <a> then search is not working. I have tried to emulate with cursor: pointer, but it does not work. This search input is generated by the script so I can not control it... BTW you can click on the flag also, not only on the arrow.

avatar b2z
b2z - comment - 3 Mar 2015

Do you have any CSS expert that could help?

avatar elkuku
elkuku - comment - 3 Mar 2015

Testing with a tablet, this works very well.

:+1:

avatar b2z
b2z - comment - 7 Mar 2015

Guys! I fixed both proposals with the help of @alldar. Please check it now is it ok? :wink:

avatar brianteeman
brianteeman - comment - 7 Mar 2015

It looks awesome to me

On 7 March 2015 at 09:37, Dmitry Rekun notifications@github.com wrote:

Guys! I fixed both proposals with the help of @alldar
https://github.com/alldar. Please check it now is it ok? [image: :wink:]


Reply to this email directly or view it on GitHub
#628 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar b2z
b2z - comment - 7 Mar 2015

If so, can be merged :smile: @mbabker can you look on #626 also please.

avatar mbabker mbabker - reference | e47dbe1 - 7 Mar 15
avatar mbabker mbabker - merge - 7 Mar 2015
avatar mbabker mbabker - close - 7 Mar 2015
avatar mbabker mbabker - change - 7 Mar 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-03-07 18:01:59
avatar mbabker mbabker - close - 7 Mar 2015
avatar mbabker mbabker - head_ref_deleted - 7 Mar 2015

Add a Comment

Login with GitHub to post a comment