[#626] - Add "No code attached yet" label for CMS issues. Fix #590.
- Closed
- 7 Mar 2015
- Medium
- Build: master
- # 626
- Diff
- joomla:issue-590
- Success continuous-integration/travis-ci/push The Travis CI build passed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
I have not tested this in any way, but from what I can remember this code will not be executed if the issue is added by the hook controller thingy aka created on GitHub, or am I wrong here?
You are right. Then may be the right place for adding this label would be JoomlacmsIssuesListener?
That listener adds the label already for issues created on GitHub. The label isn't added for issues created in the application.
Why we can not use it to create the same label for CMS tracker?
Because the listeners aren't in use in the main controllers right now, they're only registered to the webhooks.
Right... So when an issue is created on GitHub this listener adds no code label back on GitHub. When issue is created in the application this listener does not run, then my commit is ok? 
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-07 18:05:06 |
It's an ugly workaround but it would work.
I know :(
@mbabker did you miss it or you think that it is wrong implementation? I know that it is also project specific, but there is no other way currently how we can make JBS work easier...