avatar tramber91
tramber91
25 Feb 2015

Hi
Issue when I add a page class on contact menu item. I need a space to use the new class

Line 16 of /components/com_contact/views/contact/tmpl/default.php should have a space added after the contact class.
Out of that the new class is sticked to the contact like class="contactnewclass"

System information (as much as possible)

joomla 3.4 and below

Additional comments

avatar tramber91 tramber91 - open - 25 Feb 2015
avatar brianteeman
brianteeman - comment - 25 Feb 2015

The default documented action when adding any new class in the relevant
fields is always to precede it with a space.

On 25 February 2015 at 23:45, tramber91 notifications@github.com wrote:

Hi
Issue when I add a page class on contact menu item. I need a space to use
the new class

Line 16 of /components/com_contact/views/contact/tmpl/default.php should
have a space added after the contact class.
Out of that the new class is sticked to the contact like
class="contactnewclass"
System information (as much as possible)

joomla 3.4 and below
Additional comments


Reply to this email directly or view it on GitHub
#624.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar b2z
b2z - comment - 26 Feb 2015

Hi!

This is tracker for JIssues Project, not for CMS. Anyway @brianteeman is right - you should always precede it with a space if you want to add as a separate class, not a suffix to existing.

P.S.
http://issues.joomla.org/ - issue tracker for Joomla! CMS.

avatar b2z b2z - change - 26 Feb 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-02-26 08:32:44
avatar b2z b2z - close - 26 Feb 2015
avatar b2z b2z - close - 26 Feb 2015
avatar brianteeman
brianteeman - comment - 26 Feb 2015

Oops I didnt notice that the post was on the wrong tracker.

On 26 February 2015 at 08:32, Dmitry Rekun notifications@github.com wrote:

Hi!

This is tracker for JIssues Project, not for CMS. Anyway @brianteeman
https://github.com/brianteeman is right - you should always precede it
with a space if you want to add as a separate class, not a suffix to
existing.


Reply to this email directly or view it on GitHub
#624 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar tramber91
tramber91 - comment - 26 Feb 2015

Curious I was sure to add a comment, I retry?
You close the post OK

But for my side I have an issue with Rockettheme template contact page. And they told me that issue coming from Joomla!

So, I agree that It is OK for contact class itself when I add a space before class but, in that case, I cannot play with the body class because Joomla add a minus "-" instead of space to my custom class (page class)
change " newclass" by "-newclass"

avatar brianteeman
brianteeman - comment - 26 Feb 2015

The correct tracker is http://issues.joomla.org/tracker/joomla-cms

On 26 February 2015 at 13:10, tramber91 notifications@github.com wrote:

Curious I was sure to add a comment, I retry?
You close the post OK

But for my side I have an issue with Rockettheme template contact page.
And they told me that issue coming from Joomla!

So, I agree that It is OK for contact class itself when I add a space
before class but, in that case, I cannot play with the body class because
Joomla add a minus "-" instead of space to my custom class (page class)
change " newclass" by "-newclass"


Reply to this email directly or view it on GitHub
#624 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar tramber91
tramber91 - comment - 26 Feb 2015

Thanks sorry Brian
I have to recreate a post ?

avatar b2z
b2z - comment - 26 Feb 2015

@tramber91 I am not sure that this is an issue of CMS. We have a consistent behavior between all CMS components - this is a class suffix, not a separate class. It always was. So the contact page design of Rockettheme template is wrong if it does not support the default behavior of the CMS.

avatar tramber91
tramber91 - comment - 26 Feb 2015

Ok thanks
anyway i can found a trick to resolve my contact page issue (In french) it is OK in english
My first post in your bug tracker tools !! Not a bug, Not in right place, should be better next time ;=)

have a nice day

take care

avatar b2z
b2z - comment - 26 Feb 2015

@tramber91 nobody is perfect :wink: Take care

Add a Comment

Login with GitHub to post a comment