[#581] - Fix bug in latest filter package. Fixes #579
- Closed
- 3 Feb 2015
- Medium
- Build: master
- # 581
- Diff
- wilsonge:issuefix
- Success continuous-integration/travis-ci The Travis CI build passed Details
User tests: Successful: Unsuccessful:
"If the value attribute is not specified, the content will be passed as a value instead." (http://www.w3schools.com/tags/att_option_value.asp - the most reliable source ever).
Michael stated in #579 that the values from the database where
["rel_type"] => string(0) ""
["milestone_id"] => string(12) "No Milestone"
This fixes that by specifying a default value of 0 for both fields (which isn't a possible relation for the 2 fields). If this value is met then in the model they are set to null (note I don't know whether these checks for 0 are better done in model or table - I was strongly tempted to put them into App\Tracker\Table\IssuesTable::check() function tbh)
Note I have absolutely no virtual box for this thing set up so you MUST test this before merging
bump?
I think it's in line with what we are doing currently (checking/filtering in the controller before passing the data to the table class), so I believe we can move this code with the rest when we decide on how to refactor.
@wilsonge honestly this slipped somehow but looking at the submission date that may explain some things... sorry for the delay and thanks for the bump 
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-03 02:04:59 |
Yeah don't worry - it was that time of year :) Thanks for merging it!!
mbabker
-
Test passed ;) Thanks. But I would like to see checks in the Table. @mbabker @elkuku ?