Joomla! Issue Tracker - J!Tracker

Download
Launch
Feeling Lucky

[#578] - Add the 'No category' selection; Ref #538

Success

User tests: Successful: Unsuccessful:

avatar allenzhao
allenzhao
9 Dec 2014

This should add the No category selection to category filter.
Please review @elkuku @b2z
Thanks!

PS: If I miss something while I'm not active, please let me know. Sorry for the late implementation of this function

avatar allenzhao allenzhao - open - 9 Dec 2014
avatar allenzhao
allenzhao - comment - 9 Dec 2014

And what can I help with? Please give me some help:)

avatar allenzhao
allenzhao - comment - 12 Dec 2014

@b2z Fixed that, thanks!
Test is needed here because after I updated the db everything is missing and due to the block of GitHub, it seems impossible for me to retrieve data, so I only did a little test.
Still trying to get the data...

avatar b2z
b2z - comment - 12 Dec 2014

I always test before the merge :wink:

avatar b2z b2z - close - 12 Dec 2014
avatar b2z b2z - close - 12 Dec 2014
avatar b2z b2z - change - 12 Dec 2014
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-12-12 14:31:30
avatar b2z b2z - reopen - 12 Dec 2014
avatar b2z b2z - reopen - 12 Dec 2014
avatar b2z
b2z - comment - 12 Dec 2014

Oops wrong button :octocat:

avatar b2z
b2z - comment - 12 Dec 2014

Tested. All is ok except GET request filter. To make it work you should update this line to:

if ($categoryAlias != '' && $categoryAlias != -1)

avatar allenzhao
allenzhao - comment - 20 Dec 2014

Now after 28d8775 it should be good;)
Plus I've merged from master. Is it necessary before merging in?

avatar b2z b2z - close - 20 Dec 2014
avatar b2z b2z - reference | - 20 Dec 14
avatar b2z b2z - merge - 20 Dec 2014
avatar b2z b2z - close - 20 Dec 2014
avatar b2z b2z - change - 20 Dec 2014
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-12-20 15:04:57
avatar b2z
b2z - comment - 20 Dec 2014

I've merged from master. Is it necessary before merging in?

Not neccessary if there are no conflicts. Anyway merged :wink: :+1:

avatar allenzhao allenzhao - head_ref_deleted - 23 Dec 2014

Add a Comment

Login with GitHub to post a comment