Success

User tests: Successful: Unsuccessful:

avatar b2z
b2z
29 Nov 2014

This PR will allow to display vote results after the first vote. Ref #568

You can test this PR on my testing website

avatar b2z b2z - open - 29 Nov 2014
avatar b2z
b2z - comment - 30 Nov 2014

@roland-d when you have time please take a look on it.

avatar roland-d
roland-d - comment - 30 Nov 2014

@b2z I tested it out on your test website and it works as expected.

I did find another visual issue. When I submit the vote results the button text changes to Vote successfully added and is no longer clickable. The test results however, adds a text above the button "Test successfully added" and the button remains as is. Shouldn't these 2 be consistent?

avatar b2z
b2z - comment - 30 Nov 2014

@roland-d agree. Just added and updated test website.

avatar roland-d
roland-d - comment - 1 Dec 2014

@b2z Works as expected, the behavior is consistent now.

avatar b2z
b2z - comment - 1 Dec 2014

@elkuku or @mbabker please review and may be merge? :tongue:

avatar b2z
b2z - comment - 1 Dec 2014

No, wait :smile: I found two small issues (does not affect code functionality). Fill fix them and then it will be ready to merge ;) @elkuku or @mbabker if you agree for merge just leave a comment. I will merge by myself then ;)

avatar elkuku
elkuku - comment - 2 Dec 2014

Tested successfully, code looks good.

avatar b2z b2z - close - 2 Dec 2014
avatar b2z b2z - reference | - 2 Dec 14
avatar b2z b2z - merge - 2 Dec 2014
avatar b2z b2z - close - 2 Dec 2014
avatar b2z b2z - change - 2 Dec 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-12-02 05:39:48
avatar b2z b2z - head_ref_deleted - 2 Dec 2014
avatar b2z
b2z - comment - 2 Dec 2014

Thanks all for testing :+1:

Add a Comment

Login with GitHub to post a comment