enhancement Pending

User tests: Successful: Unsuccessful:

avatar phproberto
phproberto
31 Dec 2012

I wanted to add a comment counter in the issue list view.

Please review:

1.- I added the comment count after the issue title and it's only shown when there are comments. I thought about adding a column but not sure if I like that.

Suggestions are welcome. This is how it's shown:

test

2.- I had to patch the _getListCount method in:

libraries/tracker/model/tracker/list.php

to clear the group because after adding comments count it was only returning 1.

avatar phproberto phproberto - open - 31 Dec 2012
avatar phproberto phproberto - open - 31 Dec 2012
avatar dongilbert
dongilbert - comment - 4 Jan 2013

I think it could go next to the GitHub ID block and look nice. It wouldn't unnecessarily add length to the item title, and would make better use of the space. What do you think?

avatar n9iels
n9iels - comment - 7 Jan 2013

I think so it is better for the overview, if you put the comment counter next tot the GitHub ID collom you get a list information.

Where will this component be use for?

avatar elkuku
elkuku - comment - 7 Jan 2013

It's an interesting idea and I also thought about something like this when testing the comments stuff.

I know @mbabker is working on the event stream thingy so the table already has been renamed and the fields are most probably going to change.

I think we should put this back for a moment, but definitely not out of scope ;)

avatar mbabker
mbabker - comment - 7 Jan 2013

That's at #66 if you're interested.

On Monday, January 7, 2013, Nikolai Plath wrote:

It's an interesting idea and I also thought about something like this when
testing the comments stuff.

I know @mbabker https://github.com/mbabker is working on the event
stream thingy so the table already has been renamed and the fields are most
probably going to change.

I think we should put this back for a moment, but definitely not out of
scope ;)


Reply to this email directly or view it on GitHubhttps://github.com/JTracker/jissues/pull/56#issuecomment-11972861.

  • Michael

Please pardon any errors, this message was sent from my iPhone.

avatar phproberto
phproberto - comment - 8 Jan 2013

I also think that it's better show comment count next to the Github ID

After checking #66 I'm going to pause this until we decide the definitive DB structure.

Thanks all for your feedback!

avatar elkuku elkuku - reference | - 20 Jun 13
avatar mbabker mbabker - close - 3 Aug 2013
avatar - close - 3 Aug 2013
avatar phproberto phproberto - head_ref_deleted - 2 Feb 2014

Add a Comment

Login with GitHub to post a comment