bug v1.0
avatar garstud
garstud
9 Oct 2014

Steps to reproduce the issue

  • edit a 'Joomla CMS' issue in J!Tracker that have categories setted
  • save the issue
    the categories list is not accessible when editing the issue, so when we save the issue, categories (aka. colored labels) are lost !

Expected result

The category list in the right column must be displayed when editing an issue, so we can change them and they are not lost when saving.

Actual result

screen shot 2014-10-10 at 05 02 50

System information (as much as possible)

Additional comments

avatar garstud garstud - open - 9 Oct 2014
avatar garstud garstud - change - 9 Oct 2014
The description was changed
avatar b2z
b2z - comment - 10 Oct 2014

Hmm. I can not reproduce it. See my test 1 and test 2. Can you make screenshots where you can not see categories list?

avatar garstud garstud - change - 10 Oct 2014
The description was changed
avatar garstud garstud - change - 10 Oct 2014
The description was changed
avatar garstud
garstud - comment - 10 Oct 2014

Ok i had a screenshot with the edit screen. i have no options on right side to set categories, build version...

This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/525.

avatar b2z
b2z - comment - 10 Oct 2014

Aha, now I got it. It's a permissions issue. Currently we are showing such info only for users who has full edit rights (like JBS members).

The questions is - should we allow more for general users?

@brianteeman @Bakual @zero-24 @infograf768 @Kubik-Rubik @roland-d @vdespa @gwsdesk

avatar b2z b2z - change - 10 Oct 2014
Labels Added: question
avatar b2z b2z - change - 10 Oct 2014
Labels Added: UI
avatar brianteeman
brianteeman - comment - 10 Oct 2014

i would personally prefer it if categories can only be set at the time of submitting an issue by regular users.

we could have a scenario where a user submits an issue as ACL, we correct it as External Libraries and they disagree and want to change it back.

it would be the same with setting the priority level

avatar b2z
b2z - comment - 10 Oct 2014

And what about other fields like: build, easy test and milestones?

avatar brianteeman
brianteeman - comment - 10 Oct 2014

i dont personally see a need for them to be ever editable by the poster. do
you?

On 10 October 2014 12:24, Dmitry Rekun notifications@github.com wrote:

And what about other fields like: build, easy test and milestones?


Reply to this email directly or view it on GitHub
#525 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar garstud
garstud - comment - 10 Oct 2014

Ok, permissions issues, good work, thanks @b2z .

But the trouble is that if i edit the description of my issue and save it, all the categories are erased, and i cannot re-select them :(

I agree with @brianteeman , user can set initials values for build, priority and categories. But when he come back to edit the issue, the 'basic user' (like me) doesn't need to set/change the build, priority and categories values.

Maybe, some "experimeted users" can be affected to another groups to have rights to change these values, but not the basic user !?

This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/525.

avatar brianteeman
brianteeman - comment - 10 Oct 2014

its definitely a bug if when you edit the post you lose the categories etc.

On 10 October 2014 12:56, Marc STUDER notifications@github.com wrote:

Ok, permissions issues, good work, thanks @b2z https://github.com/b2z .

But the trouble is that if i edit the description of my issue and save it,
all the categories are erased, and i cannot re-select them :(

I agree with @brianteeman https://github.com/brianteeman , user can set
initials values for build, priority and categories. But when he come back
to edit the issue, the 'basic user' (like me) doesn't need to set/change
the build, priority and categories values.

Maybe, some "experimeted users" can be affected to another groups to have
rights to change these values, but not the basic user !?

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/jtracker/525
http://issues.joomla.org/tracker/jtracker/525.


Reply to this email directly or view it on GitHub
#525 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar b2z b2z - change - 10 Oct 2014
Labels Added: bug
avatar elkuku elkuku - change - 10 Oct 2014
Labels Removed: question
avatar elkuku
elkuku - comment - 10 Oct 2014

I'd also vote for bug.

Is @allenzhao still with us? :wink:

avatar allenzhao
allenzhao - comment - 10 Oct 2014

I'm here, just needs a little catch up.
So now the bug shows when a user without 'edit' permissions edit his /her own issue, category will lose?
I've got a proposal for this, since it's his/ her own issue(opened by him/her), we allow him/her to edit the categories on it?

avatar allenzhao
allenzhao - comment - 10 Oct 2014

Oh sorry, didn't see the discussion above. So when a poster modifies the issue, this whole behavior won't affect the categories on it, right?
Anyone against this or I will start to work on it ;)

avatar allenzhao
allenzhao - comment - 10 Oct 2014

It's pretty weird now, I've opened #526 to test, but I can't edit my own issue, locally
and on i.j.o, there was a quick 'undefined index' error that passed away before I can really recognize it. Can any of you go through the error log pls?
I've committed PR, but haven't test it. Needs to figure out why I can't edit my own issue...

avatar elkuku
elkuku - comment - 10 Oct 2014

there was a quick 'undefined index'

This seems unrelated:

PHP Notice:  Undefined index: milestone_id in .../App/Tracker/Model/IssueModel.php on line 375

my bad :(

Glad you're still with us :wink:

avatar allenzhao
allenzhao - comment - 10 Oct 2014

I'm busy preparing for graduate school entrance exams but still got some time;)


Sent from Mailbox

On Fri, Oct 10, 2014 at 11:59 PM, Nikolai Plath notifications@github.com
wrote:

there was a quick 'undefined index'
This seems unrelated:

PHP Notice:  Undefined index: milestone_id in .../App/Tracker/Model/IssueModel.php on line 375

my bad :(

Glad you're still with us :wink:

Reply to this email directly or view it on GitHub:
#525 (comment)

avatar elkuku elkuku - close - 10 Oct 2014
avatar elkuku elkuku - close - 10 Oct 2014
avatar elkuku elkuku - close - 10 Oct 2014
avatar elkuku elkuku - close - 10 Oct 2014
avatar elkuku elkuku - reference | - 10 Oct 14
avatar elkuku elkuku - change - 10 Oct 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-10-10 16:10:19
avatar b2z
b2z - comment - 11 Oct 2014

Joomla! Logo JTracker Status Comment


issues.joomla.org/tracker/jtracker/525

Easy: No
Successfull Tests: 0
Unsuccessfull Tests: 0


Last updated on 11 Oct 2014 20:01:37 GMT

avatar elkuku elkuku - change - 12 Oct 2014
Labels Removed: UI
avatar elkuku elkuku - change - 12 Oct 2014
Labels Added: v1.0

Add a Comment

Login with GitHub to post a comment