the selected category will show
is show html code like
<span class="label" style="background-color: #eb6420;"> </span>Front End
If we select more than one category it is ok.
| Title |
|
||||||
| Labels |
Added:
bug
UI
|
||||||
| Title |
|
||||||
| Labels |
Added:
bug
UI
|
||||||
Its bad code not bad UI. Where did you get that selector code from
On 28 September 2014 16:28, Nikolai Plath notifications@github.com wrote:
Confirmed. Looks ugly.
UI guys please
—
Reply to this email directly or view it on GitHub
#514 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
It is the trick that the selectpicker script uses to display the tiny colored box using the title attribute.
I wouldn't consider it bad code, it just has some unwanted side efects ![]()
My point is that it is a code issue not a UI issue ;)
On 28 September 2014 16:51, Nikolai Plath notifications@github.com wrote:
It is the trick that the selectpicker script uses to display the tiny
colored box using the title attribute.
I wouldn't consider it bad code, it just has some unwanted side efects [image:
]
—
Reply to this email directly or view it on GitHub
#514 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
This seems like it's working now?
This seems like it's working now?
No I have still the same issue on issues.joomla.org
Oh, I see it now. It's a bug in the parent project (http://silviomoreto.github.io/bootstrap-select/ and you can see it in the demo for the data-content attribute). When it's updating, the script should strip HTML before setting the container's title attribute.
It's a bug in the parent project
Good find... Has this been reported yet?
Yep, found silviomoreto/bootstrap-select#620 just now.
| Title |
|
||||||
| Labels |
Added:
upstream dependency
|
||||||
So they committed a fix against that issue. It looks like if we specify a title attribute on the option, that will be preferred over the data-content attribute specifically for the selector's title. We just need them to release at least 1.6.4 first, or if Bower allows dev-master type versions then we can implement it immediately.
@mbabker 1.6.4 is released see: https://github.com/silviomoreto/bootstrap-select/releases/tag/v1.6.4
| Title |
|
||||||
| Status | New | ⇒ | Closed | ||||
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-04-11 10:10:15 | ||||
Ran a Bower update and deploying updated media to live now.
but it works
Thanks!
There isn't a lock file like for Composer that you would see a version change and the www/vendor folder that Bower assets are downloaded to is gitignored.
Confirmed. Looks ugly.
UI guys please