UI bug upstream dependency
avatar zero-24
zero-24
28 Sep 2014

Steps to reproduce the issue

  1. edit a issue
  2. add one category (e.g. Fronted)
  3. mouseover the dropdown

Expected result

the selected category will show

Actual result

is show html code like
<span class="label" style="background-color: #eb6420;"> </span>Front End

Additional comments

If we select more than one category it is ok.

avatar zero-24 zero-24 - open - 28 Sep 2014
avatar elkuku elkuku - change - 28 Sep 2014
Title
Categories mouseover show html
Categories mouseover show html
Labels Added: bug UI
avatar elkuku elkuku - change - 28 Sep 2014
Title
Categories mouseover show html
Categories mouseover show html
Labels Added: bug UI
avatar elkuku
elkuku - comment - 28 Sep 2014

Confirmed. Looks ugly.

UI guys please

avatar brianteeman
brianteeman - comment - 28 Sep 2014

Its bad code not bad UI. Where did you get that selector code from

On 28 September 2014 16:28, Nikolai Plath notifications@github.com wrote:

Confirmed. Looks ugly.

UI guys please


Reply to this email directly or view it on GitHub
#514 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar elkuku
elkuku - comment - 28 Sep 2014

It is the trick that the selectpicker script uses to display the tiny colored box using the title attribute.
I wouldn't consider it bad code, it just has some unwanted side efects :wink:

avatar brianteeman
brianteeman - comment - 28 Sep 2014

My point is that it is a code issue not a UI issue ;)

On 28 September 2014 16:51, Nikolai Plath notifications@github.com wrote:

It is the trick that the selectpicker script uses to display the tiny
colored box using the title attribute.
I wouldn't consider it bad code, it just has some unwanted side efects [image:
:wink:]


Reply to this email directly or view it on GitHub
#514 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar mbabker
mbabker - comment - 25 Dec 2014

This seems like it's working now?

avatar zero-24
zero-24 - comment - 25 Dec 2014

This seems like it's working now?

No I have still the same issue on issues.joomla.org

avatar mbabker
mbabker - comment - 28 Dec 2014

Oh, I see it now. It's a bug in the parent project (http://silviomoreto.github.io/bootstrap-select/ and you can see it in the demo for the data-content attribute). When it's updating, the script should strip HTML before setting the container's title attribute.

avatar elkuku
elkuku - comment - 28 Dec 2014

It's a bug in the parent project

Good find... Has this been reported yet?

avatar mbabker
mbabker - comment - 28 Dec 2014

Yep, found silviomoreto/bootstrap-select#620 just now.

avatar mbabker mbabker - change - 28 Dec 2014
Title
Categories mouseover show html
Categories mouseover show html
Labels Added: upstream dependency
avatar mbabker
mbabker - comment - 28 Dec 2014

So they committed a fix against that issue. It looks like if we specify a title attribute on the option, that will be preferred over the data-content attribute specifically for the selector's title. We just need them to release at least 1.6.4 first, or if Bower allows dev-master type versions then we can implement it immediately.

avatar mbabker mbabker - change - 11 Apr 2015
Title
Categories mouseover show html
Categories mouseover show html
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-04-11 10:10:15
avatar mbabker mbabker - close - 11 Apr 2015
avatar mbabker mbabker - close - 11 Apr 2015
avatar mbabker
mbabker - comment - 11 Apr 2015

Ran a Bower update and deploying updated media to live now.

avatar zero-24
zero-24 - comment - 11 Apr 2015

hmm is it expeced that we don't see the changes here? d120759

avatar zero-24
zero-24 - comment - 11 Apr 2015

but it works :smile: Thanks!

avatar mbabker
mbabker - comment - 11 Apr 2015

There isn't a lock file like for Composer that you would see a version change and the www/vendor folder that Bower assets are downloaded to is gitignored.

avatar zero-24
zero-24 - comment - 11 Apr 2015

Thanks!
hmm maybe realted that the search box is not closed now?
dropdown

Add a Comment

Login with GitHub to post a comment