GitHub sync enhancement
avatar dgrammatiko
dgrammatiko
25 Sep 2014

New feature

If you do a test on a PR (successful or not) and you report it in github J!Tracker will not change the state of tests as that input was not provided.
I propose the use of a shortcut that the tracker will translate to input for the test, something like [test=pass] and [test=fail].

avatar dgt41 dgt41 - open - 25 Sep 2014
avatar b2z
b2z - comment - 25 Sep 2014

The idea with tests is that people should left their test results only on new tracker and not in the comments. Now we have some kind of transition time when people get used to it. And parsing of comments is not the best option for me personally.

avatar dgt41
dgt41 - comment - 25 Sep 2014

I guess we have to adjust to the new workflow

avatar elkuku
elkuku - comment - 28 Sep 2014

I'd also like to keep us from parsing the comments.

What we could do is displaying the test results form JTracker in GitHub, if this is usefull?

avatar elkuku elkuku - change - 28 Sep 2014
Labels Added: enhancement GitHub sync
avatar b2z
b2z - comment - 2 Oct 2014

What we could do is displaying the test results form JTracker in GitHub, if this is usefull?

I think that this definitely will be useful, but how to display them? Using some special label? ;)

avatar elkuku
elkuku - comment - 2 Oct 2014

I am thinking since some time about a special "Jtracker comment" that might hold all information not present on GitHub (Travis and Scrutinizer results, user test results, maybe checkstyle errors, etc.).
This comment would be updated whenever the information on JTracker changes.

Using a label would be another option..

avatar dgt41
dgt41 - comment - 11 Oct 2014

@b2z I would like this as a one line signature
E.g. we can use the joomla logo with the text JTracker
And then have an anchored text only the number of the issue in your example: issue: 510
Then another text easy: and then octoicon F03A (ok) or F081 (x)
Then text Tests: 0:octoicon F03A 0: F081 (x)

here are some of the available icons:
screen shot 2014-10-11 at 15 26 17

This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/510.

avatar b2z
b2z - comment - 12 Oct 2014

@dgt41 do you mean one line comment? BTW feel free to discuss it in #520

avatar elkuku
elkuku - comment - 12 Oct 2014

I'd like to use octicons since we also have them available on issues.joomla.org.
But how could we display them, using markdown, both on our site and on GitHub?

avatar dgt41
dgt41 - comment - 12 Oct 2014

For sure we can use emoticons, here is the full list
http://www.emoji-cheat-sheet.com

avatar dgt41
dgt41 - comment - 12 Oct 2014

Testing:

Easy: :heavy_plus_sign: or :heavy_minus_sign: || Tests: Passing: 0 :ballot_box_with_check: Failing: 0 :heavy_multiplication_x:

avatar dgt41
dgt41 - comment - 12 Oct 2014

Easy: :heavy_plus_sign: or :heavy_minus_sign: Tests: Passing: 0 :ballot_box_with_check: Failing: 0 :heavy_multiplication_x:

avatar dgt41 dgt41 - close - 12 Oct 2014
avatar dgt41 dgt41 - close - 12 Oct 2014
avatar dgt41 dgt41 - change - 12 Oct 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-10-12 15:46:58
avatar dgt41 dgt41 - reopen - 12 Oct 2014
avatar dgt41 dgt41 - reopen - 12 Oct 2014
avatar dgt41 dgt41 - change - 12 Oct 2014
Status Closed New
avatar elkuku
elkuku - comment - 12 Oct 2014

:+1: Great idea :clap: I totally :sparkling_heart: emojis - (we should support auto complete in JTracker :yum: )

Currently this file is in @elkuku's repo (blame PHPStorm...) written in mustache.
https://github.com/elkuku/jissues/blob/github-status-comment/src/App/Tracker/tpl/github-status-comment.mustache
Fell free to modify and send a PR :wink:

avatar allenzhao
allenzhao - comment - 16 Oct 2014

Great idea I totally emojis - (we should support auto complete in JTracker )

@elkuku https://github.com/ichord/At.js

Somehow I've starred this project months ago and I think this could help:)

avatar elkuku
elkuku - comment - 16 Oct 2014

https://github.com/ichord/At.js

Totally :heart: it - Thanks for sharing!

avatar roland-d
roland-d - comment - 20 Nov 2014

It's been awhile since there was any comment on this, so here I go. @dgt41 pointed this thread out to me because I am having quite some trouble recognizing test results in the issues. I have to scan all the comments to make sure there are enough tests. People who comment via GitHub will never use our Test result module.

Coming up with something that could help us out would be nice. I do agree with @b2z that parsing text is not ideal. We could get false test results. This issue can probably be closed and continued in #520.

avatar b2z
b2z - comment - 20 Nov 2014

Closed in favor of #520

avatar b2z b2z - close - 20 Nov 2014
avatar b2z b2z - close - 20 Nov 2014
avatar b2z b2z - change - 20 Nov 2014
Status New Closed
Closed_Date 2014-10-12 15:46:58 2014-11-20 07:04:53

Add a Comment

Login with GitHub to post a comment