bug
avatar b2z
b2z
22 Sep 2014

After deploying #500 on live site I've noticed that getContrastColor() here is not working. It is always returning white value and categories is not always readable...

It could be one of two problems:

  1. It's my bug. We should do getContrastColor(color) as I initialized [% var color = category.color; %], but left it as getContrastColor(category.color) :( If so it will be an easy fix.
  2. It is because Twig functions are not working inside the JS template. If so the only options will be to create the same as was done for labels.
avatar b2z b2z - open - 22 Sep 2014
avatar b2z b2z - change - 22 Sep 2014
Labels Added: bug
avatar b2z
b2z - assign - 22 Sep 2014
Assigned to b2z
avatar elkuku
elkuku - comment - 22 Sep 2014

I think it's because the Twig function is executed only once when the template is rendered, while the JS template is used after the page is rendered, so you can't use Twig functions anymore..

Sorry, I fixed this before reading the issue so I think this can be closed ;)

avatar elkuku elkuku - close - 22 Sep 2014
avatar elkuku elkuku - close - 22 Sep 2014
avatar elkuku elkuku - change - 22 Sep 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-09-22 14:04:11
avatar allenzhao
allenzhao - comment - 22 Sep 2014

I've noticed that in page, the template got 'white' right after Twig rendered page.

avatar allenzhao
allenzhao - comment - 22 Sep 2014

Ha @elkuku We're talking about the same thing;)

avatar b2z
b2z - comment - 22 Sep 2014

Now I got it. That is why you've made a bunch of JS functions ;)

avatar mbabker
mbabker - comment - 22 Sep 2014

Whatever was committed was pushed up.

avatar b2z
b2z - comment - 22 Sep 2014

:+1:

avatar b2z
b2z - comment - 11 Oct 2014

Joomla! Logo JTracker Status Comment


issues.joomla.org/tracker/jtracker/502

Easy: No
Successfull Tests: 0
Unsuccessfull Tests: 0


Last updated on 11 Oct 2014 20:00:58 GMT

Add a Comment

Login with GitHub to post a comment