duplicate
avatar zero-24
zero-24
14 Sep 2014

Steps to reproduce the issue

See here:
http://issues.joomla.org/tracker/joomla-cms/4278

I have update the status from Pending to RTC but it don't add the label on github (joomla/joomla-cms#4278).

See also here:
http://issues.joomla.org/tracker/joomla-cms/4274

I have update the status from Pending to RTC after this i have add a commit (fixing CS) than the jissues-bot add the label (joomla/joomla-cms#4274).

Expected result

If i update the status on JIssues to RTC the label on github will add.

Actual result

Only if i set the status to RTC and after this commit some code the label get add on github

Additional comments

This function was introduced with this commit: 08be5c5 and use onPullAfterUpdate Hook/Event. But it looks like that it is never trigger by update the state on Jissues only.

A other example that do similar is the closed state. If I close a issue on Jissues the jissues-bot will do it immediately on github.
The same thing I would expect for the RTC state.

So the code for the Closed state is here:
https://github.com/joomla/jissues/blob/master/src/App/Tracker/Controller/Issue/Save.php#L216-243

I think we should trigger here also the adding of the RTC label.

I think here: https://github.com/joomla/jissues/blob/master/src/App/Tracker/Controller/Issue/Save.php#L144
or here:
https://github.com/joomla/jissues/blob/master/src/App/Tracker/Controller/Issue/Save.php#L187
can be a good place to do this.

avatar zero-24 zero-24 - open - 14 Sep 2014
avatar b2z
b2z - comment - 15 Sep 2014

Currently we do not support sync of statuses from tracker to GitHub. See #318. It is in plans. There are some things to discuss before and on implementation.

#318 I have assigned to myself, but first I would like to implement #434 and #439 (more prior for JBS). Unfortunately there is a lack of time currently, so if anyone wants to take #318 and implement it - go for it.

avatar b2z b2z - change - 15 Sep 2014
Labels Added: duplicate
avatar zero-24
zero-24 - comment - 25 Sep 2014

Closing as it is a duplicate. Or more atm not supported :) thanks @b2z

avatar zero-24 zero-24 - close - 25 Sep 2014
avatar zero-24 zero-24 - close - 25 Sep 2014
avatar zero-24 zero-24 - change - 25 Sep 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-09-25 19:15:59
avatar b2z
b2z - comment - 11 Oct 2014

Joomla! Logo JTracker Status Comment


issues.joomla.org/tracker/jtracker/492

Easy: No
Successfull Tests: 0
Unsuccessfull Tests: 0


Last updated on 11 Oct 2014 19:54:05 GMT

Add a Comment

Login with GitHub to post a comment