It's the logic in the web hooks. A close event always triggers the database to update the status to closed (see https://github.com/joomla/jissues/blob/master/src/App/Tracker/Controller/AbstractHookController.php#L460-L483). We probably need to add logic using StatusTable::getStateStatusIds() to decide whether the status should be updated by the hook to a default state (similar to what was done at 72c069f.

Agree. But what the logic should be? If we close an issue on GitHub what to do with the status of issue on tracker? Do not touch it if the global state was not changed?

Same thing I did at 72c069f basically. Basically, if an item is set to Closed on GitHub, check if the item's status on the tracker is already a status that our system considers closed and if it isn't, set the status to Closed (ID = 10). Same logic for if an item is reopened.

Then I propose to change processStatus() method in AbstractHookController. See the Gist. This will require to change ReceiveIssuesHook, because the current issue status should be passed here.

What do you think?

That should work.

Ok :) So the next steps would be:

1. Move these two lines to the top of updateData().

2. Change
   $status = $this->processStatus($action);
   to
   $status = $this->processStatus($action, $table->status);

Seems like it should do the trick

If all agree will make a PR today ;)

Agree

Great :) So PR will be done today.

Let's watch for it now.

I think it is working properly now. Thanks @b2z @mbabker

JTracker Status Comment

issues.joomla.org/tracker/jtracker/490

Easy: No
Successfull Tests: 0
Unsuccessfull Tests: 0

Last updated on 11 Oct 2014 19:54:00 GMT