User tests: Successful: Unsuccessful:
may be we should make remember me as an optional feature?
The only problem is, that it looks quite ugly placing a checkbox in the title bar along with the login button.... and the code would have to be refactored into a <form>
and make another request first to our site, just to process the "remember me" stuff, and then to GitHub to obtain the login token.
If we get an UI expert to integrate a checkbox "somewhere", I think I could refactor the code. I'm sure if I intend this we will all get fired :P
You get me wrong. I mean optional on the application level, make option in the config.
Best regards,
Dmitry
----- Reply message -----
From: "Nikolai Plath" notifications@github.com
To: "joomla/jissues" jissues@noreply.github.com
Cc: "Dmitry Rekun" bzzjuka@gmail.com
Subject: [jissues] Implement "remember me" (#439)
Date: Sun, Aug 24, 2014 15:05
may be we should make remember me as an optional feature?
The only problem is, that it looks quite ugly placing a checkbox in the title bar along with the login button.... and the code would have to be refactored into a
and make another request first to our site, just to process the "remember me" stuff, and then to GitHub to obtain the login token.If we get an UI expert to integrate a checkbox "somewhere", I think I could refactor the code. I'm sure if I intend this we will all get fired :P
—
Reply to this email directly or view it on GitHub.
Ah, that makes sense then ;)
Labels |
Added:
enhancement
|
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-26 04:16:16 |
Ya ya ya
The bot's going back to his other programmed responsibilities now that he's deployed the latest changes LOL
remember me
as an optional feature?