enhancement Success

User tests: Successful: Unsuccessful:

avatar elkuku
elkuku
24 Aug 2014

Ref #438

avatar elkuku elkuku - open - 24 Aug 2014
avatar b2z
b2z - comment - 24 Aug 2014

:+1: tested ;) One note here - may be we should make remember me as an optional feature?

avatar elkuku
elkuku - comment - 24 Aug 2014

may be we should make remember me as an optional feature?

The only problem is, that it looks quite ugly placing a checkbox in the title bar along with the login button.... and the code would have to be refactored into a <form> and make another request first to our site, just to process the "remember me" stuff, and then to GitHub to obtain the login token.

If we get an UI expert to integrate a checkbox "somewhere", I think I could refactor the code. I'm sure if I intend this we will all get fired :P

avatar b2z
b2z - comment - 24 Aug 2014

You get me wrong. I mean optional on the application level, make option in the config.

Best regards,
Dmitry

----- Reply message -----
From: "Nikolai Plath" notifications@github.com
To: "joomla/jissues" jissues@noreply.github.com
Cc: "Dmitry Rekun" bzzjuka@gmail.com
Subject: [jissues] Implement "remember me" (#439)
Date: Sun, Aug 24, 2014 15:05
may be we should make remember me as an optional feature?

The only problem is, that it looks quite ugly placing a checkbox in the title bar along with the login button.... and the code would have to be refactored into a

and make another request first to our site, just to process the "remember me" stuff, and then to GitHub to obtain the login token.

If we get an UI expert to integrate a checkbox "somewhere", I think I could refactor the code. I'm sure if I intend this we will all get fired :P


Reply to this email directly or view it on GitHub.

avatar elkuku
elkuku - comment - 24 Aug 2014

Ah, that makes sense then ;)

avatar b2z b2z - change - 24 Aug 2014
Labels Added: enhancement
avatar b2z b2z - change - 26 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-26 04:16:16
avatar b2z b2z - close - 26 Aug 2014
avatar b2z b2z - reference | - 26 Aug 14
avatar b2z b2z - merge - 26 Aug 2014
avatar b2z b2z - close - 26 Aug 2014
avatar b2z b2z - head_ref_deleted - 26 Aug 2014
avatar elkuku
elkuku - comment - 26 Aug 2014

NOTE to @deployBot: Config has changed (cc @mbabker :wink:)

avatar mbabker
mbabker - comment - 26 Aug 2014

Ya ya ya :tongue:

The bot's going back to his other programmed responsibilities now that he's deployed the latest changes LOL

Add a Comment

Login with GitHub to post a comment