Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
8 Aug 2014

This is an alternate proposal for #408 which changes the CLI script to only change the issue status if the GitHub issue state has changed. So, if an issue is already open and when the script runs the issue is now closed, then the status will be modified. But, if an issue is open and that state hasn't changed, then we won't reset the issue status back to the default open state.

//cc @elkuku @zero-24

avatar mbabker mbabker - open - 8 Aug 2014
avatar zero-24
zero-24 - comment - 9 Aug 2014

@mbabker So we don't move the itm to pending if there is code attached?

If yes. Code looks ok here.

avatar zero-24
zero-24 - comment - 9 Aug 2014

@mbabker please ignore my comment above it looks fixed with: 1bdf650

avatar mbabker
mbabker - comment - 9 Aug 2014

That cron script is mostly to make sure the data stays in sync between
GitHub and our app, so it shouldn't need to do certain processing. The
webhooks, as those are instantaneous notifications, should be where most of
the logic is at for things like this.

On Saturday, August 9, 2014, zero-24 notifications@github.com wrote:

@mbabker https://github.com/mbabker please ignore my comment above it
looks fixed with: 1bdf650
1bdf650


Reply to this email directly or view it on GitHub
#411 (comment).

avatar elkuku elkuku - change - 9 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-09 23:41:24
avatar elkuku elkuku - close - 9 Aug 2014
avatar elkuku elkuku - reference | - 9 Aug 14
avatar elkuku elkuku - merge - 9 Aug 2014
avatar elkuku elkuku - close - 9 Aug 2014
avatar elkuku elkuku - head_ref_deleted - 9 Aug 2014
avatar elkuku
elkuku - comment - 9 Aug 2014

Looks like a good solution to the problem.

Add a Comment

Login with GitHub to post a comment