Well for now need to test it :) Hope @elkuku will also review, cause it's a little bit hard for one person - too many files were changed

I found only some issues during the testing. Great job

One more thing you need to implement is displaying of changes. Here we process them. So when categories for the issue are changed, we need to display this as activity.

Is there a link to the categories list view for a project somewhere? I'm afraid I can't find it :(

Apart of that (and the code comments) it looks pretty cool. Congrats

Is there a link to the categories list view for a project somewhere? I'm afraid I can't find it :(

As far as I understand there is no link. I think it should be added under the Project menu here.

As far as I understand there is no link. I think it should be added under the Project menu here.

And here maybe

About the UI: I have been playing with the JS thingy I mentioned, displaying the labels in the issue edit view. It looks like this:

Code: https://github.com/joomla/jissues/tree/labels (compare)

Maybe you can start from here when implementing the labels functionality, and also use this list box for categories, if everybody is fine with this?

I hope it plays nicely with the "search tools" stuff

@elkuku looks nice! I am for it.

@allenzhao do you test your code locally? I advice you to test, because many bugs would be fixed before PR :)

I’ve tested, but I guess some bugs didn’t show up when I’m testing…

On August 7, 2014 at 2:27:38 PM, Dmitry Rekun (notifications@github.com) wrote:

@allenzhao do you test your code locally? I advice you to test, because many bugs would be fixed before PR :)

—
Reply to this email directly or view it on GitHub.

Well after some tests I can not find any bugs. @allenzhao you should fix all our notes and it will be ready for merge.

Oh, I forgot about UI - when will be implemented then can merge :)

For processChanges method, should it take the initial assign of categories as an item or just trigger this method when there's change in category?

I think both. It's like add category and remove category?

I think both. It's like add category and remove category?

I think I didn't get the point, can you be more specific?

In b09fdf6 I've implemented the processChanges() method. Please review.
And now I've implemented categories displaying on issue's detail page. Now it's like this:
With categories:

Without categories:

Any suggestions?
I will continue with the category choosing and editing's UI in issue edit/adding page.

@b2z @elkuku
Well after 7b1e765 I believe UIs and all the buggy codes are fixed. Please test and review.
For the fields, is description not needed? I think this will make admins more clear about what one certain category refers to.
And for created_by, I think it can be removed. So if you would want this to be removed, I will check all the codes and remove this column from mysql and remove the usages in codes.
Besides those, if there's anything missing please let me know;)

For the fields, is description not needed? I think this will make admins more clear about what one certain category refers to.

Well the name of category for me should be self explanatory, so I do not think we will need description. The field created_by also can be removed.

@allenzhao congratulations. You've made a good job Just tested - everything works as expected.

One more improvement could be for changes - currently when you change the categories for issue you have something like this in activity:
Category 4,5,8 ⇒ 4,5,10

Could be great to have the names of categories there, not the IDs.

So, now I've got three more to-dos:

• Remove the field description and created_by in sql file
• Remove the usage in codes
• Displaying names instead of IDs for category change

Then it's good to merge?

Thanks so much for all the help!

Category 4,5,8 ⇒ 4,5,10

So maybe the "proper" way would be to display only the added and removed categories? ;)

I tried to implement the "bootstrap-select" also in the list view for filtering, but it's kind of "choking" with the bootstrap "collapsible" JS/CSS thingy we have for the search tools. Was that the problem you were talking about?
Would be nice but I don't think that it's "mandatory" at this point ;)

So, now I've got three more to-dos:

Agree ;)

Otherwise I'm fine here :)

I guess it was. Actually it's kinda buggy but I don't know why. I'm not CSS expert, so I looked into the style thing but didn't get it right.

Cheers | 顺颂时祺
Allen Zhao | 赵泽涵

在 2014年8月12日，22:32，Nikolai Plath notifications@github.com 写道：

Category 4,5,8 ⇒ 4,5,10

So maybe the "proper" way would be to display only the added and removed categories? ;)

I tried to implement the "bootstrap-select" also in the list view for filtering, but it's kind of "choking" with the bootstrap "collapsible" JS/CSS thingy we have for the search tools. Was that the problem you were talking about?
Would be nice but I don't think that it's "mandatory" at this point ;)

So, now I've got three more to-dos:

Agree ;)

Otherwise I'm fine here :)

—
Reply to this email directly or view it on GitHub.

I'm not CSS expert, so I looked into the style thing but didn't get it right.

Me neither, so let's leave it as it is, since it's "usable", and we'll wait for one of those CSS guys to fix it properly ;)

So maybe the "proper" way would be to display only the added and removed categories?

Good idea.

I tried to implement the "bootstrap-select" also in the list view for filtering

IIRC we agreed not to use multiple categories for filtering.

IIRC we agreed not to use multiple categories for filtering.

Yes but the bootstrap select also offers colors and a search functionality ;)

Yes, so not using bootstrap select will let the select be ugly in appearance but does not affect its functionality;)

On August 13, 2014 at 4:30:48 AM, Nikolai Plath (notifications@github.com) wrote:

IIRC we agreed not to use multiple categories for filtering.

Yes but the bootstrap select also offers colors and a search functionality ;)

—
Reply to this email directly or view it on GitHub.

@b2z @elkuku

After 5b89e1b I think I've implemented everything;)
Correct me if there's something missing and please test and review;)

Can't believe GSoC is going to an end and finally I've finished this big feature;)

All is great! Tested again :) I have only one note above regarding the UX. Besides that => GOOD TO MERGE

And yes, that was a great experience for all of us! For me and @elkuku as a mentors and for you as a student! I'm really enjoyed working on this GSoC project and hope you too ;)

All is great! Tested again :) I have only one note above regarding the UX. Besides that => GOOD TO MERGE

Then I will change this and sync with main repo. Then you can merge it;)

And yes, that was a great experience for all of us! For me and @elkuku as a mentors and for you as a student! I'm really enjoyed working on this GSoC project and hope you too ;)

I really enjoyed GSoC and I will contribute after GSoC too! Can't make it with your help

Then I will change this and sync with main repo. Then you can merge it;)

Waiting :)

@elkuku please do a final review today and then we can merge this huge PR in :)

BTW if the PR should be merged today then I think we can do it. My previously mentioned note is just a small improvement which can be made after the merge safely.

Now it is good to merge for me! Waiting for @elkuku ;)

May I have the honor to "push that merge button" :)

Thanks a bunch @allenzhao for this great feature. - and thanks to GSoC.

It was a pleasure to have you on board and I hope you will continue contributing to the project.

It was a pleasure to have you on board and I hope you will continue contributing to the project.

I definitely will！
Thanks a billion to all the help along the way! It is really a great summer!

Assuming I didn't break anything along the way, this is now up on the live site.

Thanks a lot for your work this summer!

@mbabker That's really fast;)
Thanks again for all the help along the way this summer!
@b2z @elkuku