Feeling Lucky
[#392] - Fix #390 and modified_date bug
- Closed
- 25 Jul 2014
- Medium
- Build: master
- # 392
- Diff
- allenzhao:bugfix-save
- Success continuous-integration/travis-ci The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This should fix #390.
And I found that, modified_date has a default value of 0000-00-00 00:00:00 and not null, the original if clause didn't work as expected.
Now I've tested, it's fine
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-25 01:38:45 |
b2z
- comment
- 25 Jul 2014
Yeah this should be definitely refactored.
allenzhao
- comment
- 25 Jul 2014
Maybe just pass the username to the table?
On Jul 25, 2014, at 2:14 PM, Dmitry Rekun notifications@github.com wrote:
Yeah this should be definitely refactored.
—
Reply to this email directly or view it on GitHub.
I'm not sure that it is actually "best practice" to pass the user object with the request data, just to get the user name... but I'd prefer it instead of creating a setUser() method in the model
About the modified date: Seems the code was never working, so we have to look out for unexpected behavior now