Success

User tests: Successful: Unsuccessful:

avatar b2z
b2z
29 Jun 2014

This will make priorities to be in one place.

A question to @elkuku - is TrackerExtension.php handled by translation script? I am asking because yesNo() function inside it is not translated currently, so I am a little bit confused about it.

avatar b2z b2z - open - 29 Jun 2014
avatar elkuku
elkuku - comment - 29 Jun 2014

Do you mean this method? TrackerExtension.php::yesNo()

I'm confused why do you think it is not translated (it's here)

Otherwise the PR looks good :wink:

avatar b2z
b2z - comment - 29 Jun 2014

I'm confused why do you think it is not translated

Because I've checked on the live site and on all languages in Edit view selectlist has Yes/No.

avatar elkuku
elkuku - comment - 29 Jun 2014

Hmm, the only "Yes/No" select I can see in the issue edit view is the one for the "Easy test" select which is generated here (untranslated...)
The only usage of the yesNo method from the TrackerExtension I found here in the App Groups edit view, and that works just fine here.

avatar b2z
b2z - comment - 30 Jun 2014

The only usage of the yesNo method from the TrackerExtension I found here in the App Groups edit view, and that works just fine here.

Ok :) Then this is ready to merge ;)

avatar elkuku elkuku - change - 30 Jun 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-06-30 14:17:58
avatar elkuku elkuku - close - 30 Jun 2014
avatar elkuku elkuku - reference | - 30 Jun 14
avatar elkuku elkuku - merge - 30 Jun 2014
avatar elkuku elkuku - close - 30 Jun 2014
avatar elkuku elkuku - head_ref_deleted - 30 Jun 2014
avatar elkuku
elkuku - comment - 30 Jun 2014

on all languages in Edit view selectlist has Yes/No.

I tried to fix this in 37b5645

Add a Comment

Login with GitHub to post a comment