User tests: Successful: Unsuccessful:
This will update jquery-validation to V 1.12.0 for the following reason: The tag we are using has been removed :(
See: https://github.com/jzaefferer/jquery-validation/releases
So, maybe this needs some testing...
Go ahead and merge it. I have to manage Bower dependencies manually still
so next time I update the server I'll know to check that when I see
bower.json in the diff.
On Saturday, May 10, 2014, Dmitry Rekun notifications@github.com wrote:
Works fine, but we need @mbabker https://github.com/mbabker to merge
it, because the path was changed. So merge & bower update.—
Reply to this email directly or view it on GitHub#358 (comment)
.
If we merge it without bower update, a validation will not work. So you need to merge it first and then update deps :)
Best regards,
Dmitry
----- Reply message -----
From: "Michael Babker" notifications@github.com
To: "joomla/jissues" jissues@noreply.github.com
Cc: "Dmitry Rekun" bzzjuka@gmail.com
Subject: [jissues] Update jquery-validation to 1.12.0 (#358)
Date: Sat, May 10, 2014 20:04
Go ahead and merge it. I have to manage Bower dependencies manually still
so next time I update the server I'll know to check that when I see
bower.json in the diff.
On Saturday, May 10, 2014, Dmitry Rekun notifications@github.com wrote:
Works fine, but we need @mbabker https://github.com/mbabker to merge
it, because the path was changed. So merge & bower update.
—
Reply to this email directly or view it on GitHub#358 (comment)
.
—
Reply to this email directly or view it on GitHub.
The site isn't auto-synced. The git command runs under a different user
when set up as a cron job so I've been manually doing it. Just do it,
promise it won't break.
On Sat, May 10, 2014 at 12:07 PM, Dmitry Rekun notifications@github.comwrote:
If we merge it without bower update, a validation will not work. So you
need to merge it first and then update deps :)Best regards,
Dmitry----- Reply message -----
From: "Michael Babker" notifications@github.com
To: "joomla/jissues" jissues@noreply.github.com
Cc: "Dmitry Rekun" bzzjuka@gmail.com
Subject: [jissues] Update jquery-validation to 1.12.0 (#358)
Date: Sat, May 10, 2014 20:04
Go ahead and merge it. I have to manage Bower dependencies manually stillso next time I update the server I'll know to check that when I see
bower.json in the diff.
On Saturday, May 10, 2014, Dmitry Rekun notifications@github.com wrote:
Works fine, but we need @mbabker https://github.com/mbabker to merge
it, because the path was changed. So merge & bower update.
—
Reply to this email directly or view it on GitHub<
https://github.com/joomla/jissues/pull/358#issuecomment-42734744>.
—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub#358 (comment)
.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-05-10 18:06:01 |
Ok boss :) Merged ;)
Works fine, but we need @mbabker to merge it, because the path was changed.
So
merge
&bower update
.