[#347] - Hardcoded language strings
- Closed
- 20 Jul 2014
- Medium
- Build: master
- # 347
Steps to reproduce the issue
- Change the language to any language but English
- Post a comment
- After clicking the submit button you will see this message in English:
Submitting comment...
Expected result
The message to be in the chosen language
Actual result
The message is shown in English
System information (as much as possible)
This is triggered by line 35 in the jtracker.js file:
https://github.com/joomla/jissues/blob/master/www/jtracker/core/js/jtracker.js#L35
Additional comments
Possible all strings in JS files are current untranslatable.
Thanks for that, I have translated the 4 strings. We need to see if there are others I will see what I can found. One hard coded string I found is here:
https://github.com/joomla/jissues/blob/master/templates/tracker/issue.index.twig#L332
The word comment is hardcoded on that line.
It would be helpful if the language files could be pushed out, so I can see which have been translated :)
I've gotten the server updated (might not happen again for a few days after this now).
hmmmm.... one more time please 
Done, I'm here for another 20 minutes tops for last minute requests.
@todo modify config.json to add da-DK language
Added to the config. The UI piece of it should be usable now if you need to make config changes (at least last I tested it).
I think we can change things using the config UI, but we can not actually add an item to an array @todo
Ahh, ya, that bit is missing.
On Sunday, May 4, 2014, Nikolai Plath notifications@github.com wrote:
I think we can change things using the config UI, but we can not
actually add an item to an array @todo [image:—
Reply to this email directly or view it on GitHub#347 (comment)
.
b2z
- | Description | <h4>Steps to reproduce the issue</h4> <ol> <li>Change the language to any language but English</li> <li>Post a comment</li> <li>After clicking the submit button you will see this message in English: Submitting comment...</li> </ol><h4>Expected result</h4> <p>The message to be in the chosen language</p> <h4>Actual result</h4> <p>The message is shown in English</p> <h4>System information (as much as possible)</h4> <p>This is triggered by line 35 in the jtracker.js file:<br><a href="https://github.com/joomla/jissues/blob/master/www/jtracker/core/js/jtracker.js#L35">https://github.com/joomla/jissues/blob/master/www/jtracker/core/js/jtracker.js#L35</a></p> <h4>Additional comments</h4> <p>Possible all strings in JS files are current untranslatable.</p> | ⇒ | <h4>Steps to reproduce the issue</h4> <ol class="task-list"> <li>Change the language to any language but English</li> <li>Post a comment</li> <li>After clicking the submit button you will see this message in English: Submitting comment...</li> </ol><h4>Expected result</h4> <p>The message to be in the chosen language</p> <h4>Actual result</h4> <p>The message is shown in English</p> <h4>System information (as much as possible)</h4> <p>This is triggered by line 35 in the jtracker.js file:<br><a href="https://github.com/joomla/jissues/blob/master/www/jtracker/core/js/jtracker.js#L35">https://github.com/joomla/jissues/blob/master/www/jtracker/core/js/jtracker.js#L35</a></p> <h4>Additional comments</h4> <p>Possible all strings in JS files are current untranslatable.</p> |
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-20 18:15:54 |
Well... actually they are not "hard coded" and we have the possibility to actually translate them. It's just that
I have updated the scripts and uploaded the JS language file to Transifex:
https://opentranslators.transifex.com/projects/p/jtracker/resource/jtracker-js-corejs/
Please translate and test