Looking on the code I could say it should work (will test it tomorrow):) I have only one question - why you update status only on GitHub?

why you update status only on GitHub?

Not sure what you mean... Since GitHub has only 2 statuses (open and closed), the JTracker status value gets translated to either "open" or "closed" to match those on GitHub.
Then it will be saved to the database ;)

Hmm I do not see any status saving. Only updating it on the GitHub. But what about non-GitHub project?

The status get's sucked in and filtered in the models save() method and then saved to the issues table (@todo filter and validate somewhere else...) - I hope thats what you meant.

That would be the same for non GitHub projects..

The only issue that pops up for me here is that you can not open <=> close issues with editown permissions, but that's another topic (I hope).. ((that would require some lines of code around here))

The status get's sucked in and filtered in the models save() method and then saved to the issues table (@todo filter and validate somewhere else...) - I hope thats what you meant.

Nope. I mean that in the controller's save method status does not come in from the input.

Nope. I mean that in the controller's save method status does not come in from the input.

That code only gets executed when editown permissions are used. If you have full edit permissions all values are taken from the input here... seems like the comments should be more explicit ;)

Oh blind me...

OK, so i switched that strange try/catch to an if/else and moved the GitHub update code to a proper method.
Does that make things more clear ? (or less...)

Now it is more clear :)

What I do not like (in general) that our controllers become responsible for things that models should do. Just IMHO :)