question
avatar eddieajau
eddieajau
12 Apr 2014

I closed the issue joomla/joomla-cms#1569 on Github. The comment is currently reflected in http://issues.joomla.org/tracker/joomla-cms/1569 but the issue is not currently showing as closed. Is there a lag or is this a bug?

avatar eddieajau eddieajau - open - 12 Apr 2014
avatar mbabker
mbabker - comment - 12 Apr 2014

I think if you do comment and close, it doesn't trigger a close event the same was just clicking a close button does. We have a cron job running hourly for each project to sync up differences (one at :15 after and one at :45 after so as to not process everything all at the same time).

avatar elkuku
elkuku - comment - 13 Apr 2014

Those GitHub hooks are kinda strange beasts....
Actually the issue is displayed correctly (as closed by @eddieajau). So yes, there is a "lag".
If this becomes an issue we might increase the frequency the cron job is running.

avatar mbabker
mbabker - comment - 13 Apr 2014

Well, it was supposed to update but didn't because: [2014-04-12 17:38:28] JTracker.ERROR: Error updating GitHub issue joomla/joomla-cms #1569 in the tracker: A build is required.

I could have sworn we did something about that...

avatar elkuku
elkuku - comment - 13 Apr 2014

Umm.... in which of the log files did that message end up? (seems that they have been ""rotated"" since :wink:)

Looking at IssuesTable->check() there are several other restrictions that would not apply to GitHub issues. Time to re-think-the-thing™...

avatar mbabker
mbabker - comment - 13 Apr 2014

It was in the issue log.

In the hooks, we added code to set a build when inserting issues, but didn't handle an update condition. So, records which have been in the database for a while wouldn't pass current validation if we repeated those activities.

We might need to add a source to at least the IssuesTable object so that it can act accordingly if a record is being inserted/updated via hook, user input, or a CLI script.

avatar b2z
b2z - comment - 13 Apr 2014

We might need to add a source to at least the IssuesTable object so that it can act accordingly if a record is being inserted/updated via hook, user input, or a CLI script.

Sounds like a plan ;)

avatar elkuku
elkuku - comment - 13 Apr 2014

We might need to add a source to at least the IssuesTable object so that it can act accordingly if a record is being inserted/updated via hook, user input, or a CLI script.

Sounds like a plan ;)

A good one ;)

avatar elkuku elkuku - close - 7 Aug 2015
avatar elkuku
elkuku - comment - 7 Aug 2015

I believe this has been "fixed" since.

avatar elkuku elkuku - change - 7 Aug 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-08-07 00:44:33
Closed_By elkuku

Add a Comment

Login with GitHub to post a comment