[#329] - Edit own (Fix #236)
- Closed
- 8 Apr 2014
- Medium
- Build: master
- # 329
- Diff
- joomla:edit-own
- Success default The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This will implement "edit own" for items.
Please test and review carefully
Notes:
Currently the items that are editable with edit own permissions are hard coded. You can only edit the title and description of an item (not the status, priority etc.).
If we (re)implement custom fields, those should receive a property canEditOwn to be controlled separately.
| Description | <p>This will implement "edit own" for items.</p> <p>Please test and review carefully <img class="emoji" title=":wink:" alt=":wink:" src="https://github.global.ssl.fastly.net/images/icons/emoji/wink.png" height="20" width="20" align="absmiddle"></p> | ⇒ | <p>This will implement "edit own" for items.</p> <p>Please test and review carefully <img class="emoji" title=":wink:" alt=":wink:" src="https://github.global.ssl.fastly.net/images/icons/emoji/wink.png" height="20" width="20" align="absmiddle"></p> <p>Notes:<br> Currently the items that are editable with <code>edit own</code> permissions are hard coded. You can only edit the title and description of an item (not the status, priority etc.).<br> If we (re)implement custom fields, those should receive a property <code>canEditOwn</code> o be controlled separately.</p> |
Why you do not allow to change status? :)
I believe that not every field should be editable with "edit own" permissions. But that's only my personal opinion.
Well we have a long discussion in #318 about the status :) See this particular comment and @brianteeman's answer on it. What do you think of implementing this?
| Title |
|
||||||
I think @brianteeman also agreed that only JBS members should be allowed to change the status - I hope that's what he meant in this comment 
that only JBS members should be allowed to change the status
I don't mind, but here is the problem - on the GitHub creator of the issue can close/open it. And on the JTracker it won't ? Seems not logical.
Ahh that's true I haven't thought about that fact...
What if we add an additional checkbox saying something like "Please close this issue" on the edit form that is only visible when "editing own"?
I don't think that we should separate the open/close thingy from the status.
What if we add an additional checkbox saying something like "Please close this issue" on the edit form that is only visible when "editing own"?
May be we need something like on the GitHub? Like you can close/reopen an issue not editing it? Button acting like close/reopen.
Well we can think about the status editing later. For now I'am meging this one :)
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-04-08 19:11:30 |
Tested and it works :) Why you do not allow to change status? :)