GitHub sync enhancement
avatar brianteeman
brianteeman
9 Mar 2014

I can see how I can edit an item to change its status (is that something everyone can do or is it because of my own account settings) but is that the best way to do it. Currently you cannot change status and comment at the same time.

avatar brianteeman brianteeman - open - 9 Mar 2014
avatar brianteeman brianteeman - change - 9 Mar 2014
Status New Confirmed
avatar brianteeman brianteeman - change - 9 Mar 2014
Status Confirmed New
avatar b2z
b2z - comment - 10 Mar 2014

Do you want some AJAX way to change it? Or I miss you point?

avatar brianteeman
brianteeman - comment - 10 Mar 2014

You miss the point I think

Changing status can ONLY be done by editing the first post (and the ACL only gives that right to limited people I think)

For good workflow it should be possible for people to change the STATUS without editing the first report

AND it should be possible to change the STATUS and COMMENT at the same time.

avatar b2z
b2z - comment - 10 Mar 2014

Changing status can ONLY be done by editing the first post (and the ACL only gives that right to limited people I think)

Yes you are right. We should solve it with #236.

AND it should be possible to change the STATUS and COMMENT at the same time.

Interesting. Should it be some additional status field? If so where is the best place for it? :)

avatar b2z
b2z - comment - 11 Mar 2014

@brianteeman just to be sure that we are talking about the same thing - status is Open/Closed?

avatar brianteeman
brianteeman - comment - 11 Mar 2014

No that is not the status of an issue.
On 11 Mar 2014 20:55, "Dmitry Rekun" notifications@github.com wrote:

@brianteeman https://github.com/brianteeman just to be sure that we are
talking about the same thing - status is Open/Closed?

Reply to this email directly or view it on GitHub#318 (comment)
.

avatar b2z
b2z - comment - 12 Mar 2014

Then what you mean? confirmed/pending... ?

avatar brianteeman
brianteeman - comment - 12 Mar 2014

screen shot 2014-03-12 at 03 57 58
You may blame the J!Tracker Application for transmitting this comment.

avatar b2z
b2z - comment - 12 Mar 2014

Ok I got it. Where we can place this field? And as far as I understand we should show this field only to some groups like JBS or Admins + creator of issue?

avatar brianteeman
brianteeman - comment - 12 Mar 2014

For me this is the MOST IMPORTANT field on the entire page. It shows everyone if the issue needs testing if it needs confirming etc. so it MUST be visible to everyone and preferably something that people can filter the issue list with.
As to who can edit the value that is probably just JBS

avatar Webdongle
Webdongle - comment - 12 Mar 2014

That would make it easier for members of the JBS to recreate the reports in the current tracker to the new tracker. And would prevent accidental/unnecessary retesting of 'Confirmed' reports. Because the report (that is recreated in the new tracker) can be marked as confirmed....Also new reports in the new tracker when marked as 'Confirmed' will help prevent several members of JBS accidentally/unnecessary testing a report that has already been confirmed.

avatar b2z
b2z - comment - 13 Mar 2014

May be for better management we need to separate open/closed and give edit access for JBS/creator? And the status (without open/closed) will be available only for JBS. Does this make sense?

avatar brianteeman
brianteeman - comment - 13 Mar 2014

It does to me and its what I said 6 months ago ;)

On 13 March 2014 07:26, Dmitry Rekun notifications@github.com wrote:

May be for better management we need to separate open/closed and give editaccess for JBS/creator? And the
status (without open/closed) will be available only for JBS. Does this
make sense?

Reply to this email directly or view it on GitHub#318 (comment)
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar b2z
b2z - comment - 13 Mar 2014

:) I glad that finally this question is clear. Well I need to code then ;)

avatar brianteeman
brianteeman - comment - 13 Mar 2014

If we wanted to get very clever then the changing the status
(confirmed/pending/duplicate/) etc would also change the open/closed.
This is how it works on the current tracker where every status is part of
either the open or closed group
EG
Duplicate and fixed are always closed
So when you filter on open/closed it reads the status and decides if that is open or closed
You do not have to mark something as closed in the open/closed field. That is automatic (and perhaps readonly) based on the status

On 13 March 2014 09:40, Dmitry Rekun notifications@github.com wrote:

:) I glad that finally this question is clear. Well I need to code then ;)

Reply to this email directly or view it on GitHub#318 (comment)
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 13 Mar 2014

From the current list of status
Group Open

  • open
  • confirmed
  • pending
  • rtc
  • review
  • info

Group Closed

  • fixed
  • platform (do we still need this one?)
  • no reply
  • closed
  • expected
  • known
avatar b2z
b2z - comment - 13 Mar 2014

Yeah I see what you mean.

What I can't understand completely is this:

AND it should be possible to change the STATUS and COMMENT at the same time.

Can you elaborate from the UI view?

avatar brianteeman
brianteeman - comment - 13 Mar 2014

To change the status today I have to edit the first post and save and then
comment explaining why I changed the status and save.

If you look at joomlacode you will see I can change the status at any time.
So I can open an issue, change status and comment in one action.
On 13 Mar 2014 11:44, "Dmitry Rekun" notifications@github.com wrote:

Yeah I see what you mean.

What I can't understand completely is this:

AND it should be possible to change the STATUS and COMMENT at the same
time.

Can you elaborate from the UI view?

Reply to this email directly or view it on GitHub#318 (comment)
.

avatar b2z
b2z - comment - 14 Mar 2014

Unfortunately at joomlacode I do not see it. May be because I do not have rights to do it?

At the moment I do not have a clear picture in my mind how to achieve this at JTracker. May be some Close/Reopen button like on GitHub near the Comment button. But where to place Status field/button? Or may be some AJAX button which will allow changing the statuses one the fly?

avatar brianteeman
brianteeman - comment - 14 Mar 2014

Sorry its a large screenshot but you can see I have highlighted the status field and the comment field on joomlacode to show how a JBS member can update both at the same time. I hope that explains more clearly what I mean

screen shot 2014-03-14 at 04 14 38
You may blame the J!Tracker Application for transmitting this comment.

avatar Webdongle
Webdongle - comment - 14 Mar 2014

Close up images of the options in the 'Status' drop down box
dropdown 01
dropdown 02

avatar b2z
b2z - comment - 14 Mar 2014

Now it is clear - you have an edit view by default. But it will be almost impossible to implement :( Can we find another way? May be you click on Edit and have a comment form there? But still there is a problem to have multiple editors on the same page because of upload form... See my comment here :confused:

avatar b2z
b2z - comment - 17 Mar 2014

I think I found the way how to handle multiple editors with the one upload form on the same page. @brianteeman @Webdongle will it be enough for you to click on Edit and have a comment form there along with the other staff?

avatar brianteeman
brianteeman - comment - 17 Mar 2014

If I understand you correctly then yes but I'm still reading your mind so will have to wait till I see it

avatar b2z
b2z - comment - 17 Mar 2014

@brianteeman I have uploaded changes to live demo. You can try to edit some of the items in the JTracker project to see what I mean. Please note that a comment will not be saved, it's there just for a demo purposes currently.

avatar brianteeman
brianteeman - comment - 17 Mar 2014

I think you need to change my account acl on your site so I can test
On 17 Mar 2014 21:04, "Dmitry Rekun" notifications@github.com wrote:

@brianteeman https://github.com/brianteeman I have uploaded changes to live
demo http://tracker.j-esports.com/tracker/jtracker/. You can try to
edit some of the items in the JTracker project to see what I mean. Please
note that a comment will not be saved, it's there just for demo purposes
currently.

Reply to this email directly or view it on GitHub#318 (comment)
.

avatar b2z
b2z - comment - 17 Mar 2014

Hmm I did it. Can you relogin plz :)

avatar brianteeman
brianteeman - comment - 17 Mar 2014

I can see the edit and post now.

But new comments are not being saved. Status change is saved.
On 17 Mar 2014 21:15, "Dmitry Rekun" notifications@github.com wrote:

Hmm I did it. Can you relogin plz :)

Reply to this email directly or view it on GitHub#318 (comment)
.

avatar b2z
b2z - comment - 17 Mar 2014

But new comments are not being saved.

Yeap, that's why I wrote you earlier:

Please note that a comment will not be saved, it's there just for a demo purposes currently.

If you do like the concept then I will implement a saving logic.

avatar brianteeman
brianteeman - comment - 17 Mar 2014

Ah I misunderstood you there.
On 17 Mar 2014 21:33, "Dmitry Rekun" notifications@github.com wrote:

But new comments are not being saved.

Yeap, that's why I wrote you earlier:

Please note that a comment will not be saved, it's there just for a demo
purposes currently.

Reply to this email directly or view it on GitHub#318 (comment)
.

avatar b2z
b2z - assign - 17 Mar 2014
Assigned to b2z
avatar elkuku
elkuku - comment - 2 Apr 2014

Currently our status definitions are like this:
debug-3858
Note that the closed column separate those statuses in two "groups" e.g. open and closed. Just like @brianteeman pointed out here.
I believe that is not very visible without looking at the source code., so part of the issue may be already solved ?

The other issue here is:

  • edit the status and post a comment on the same "form"

One of the most annoying things on jcode is that it returns to the list view after saving an item.
If it would just return to the item view (like we are doing now) you could just change the status or any other field, click save, and then add your comment.

avatar b2z
b2z - comment - 2 Apr 2014

I believe that is not very visible without looking at the source code., so part of the issue may be already solved ?

I know it, but what do you mean by "part of the issue may be already solved" ?

edit the status and post a comment on the same "form"

I have already implemented it in #326

avatar elkuku
elkuku - comment - 2 Apr 2014

"part of the issue may be already solved" ?

I believe that @brianteeman and @Webdongle maybe weren't aware of that fact (or maybe they were - apologies then).

I have already implemented it in #326

Yes, but as I said, I'm not sure about the added value...

avatar b2z
b2z - comment - 2 Apr 2014

I'm not sure about the added value...

Why? This functionality will allow to implement #314

avatar b2z
b2z - comment - 18 Jul 2014

BTW do we want statuses to be visible on GitHub as labels?
@brianteeman @Webdongle @roland-d @zero-24 @Bakual

avatar brianteeman
brianteeman - comment - 18 Jul 2014

it would be useful

avatar Bakual
Bakual - comment - 18 Jul 2014

I'd like to see status, yes. Especially the not closed ones like RTC.

avatar mbabker
mbabker - comment - 18 Jul 2014

I think we have to. Just having GitHub's filters isn't efficient enough if you're browsing on GitHub. We already dealt with a situation where you can't filter PRs on the target branch by automating assigning labels for that.

avatar roland-d
roland-d - comment - 29 Jul 2014

I would like to see those labels on GitHub, it will help to quickly recognize where this issue is at in terms of progress.

avatar mbabker
mbabker - comment - 29 Jul 2014

Speaking of label management, our lives got a little easier with this update.

avatar b2z
b2z - comment - 29 Jul 2014

One more thing left - we need to define a prefix for labels which will represent the statuses. May be ~ ?

avatar roland-d
roland-d - comment - 29 Jul 2014

I like the ~ prefix.

avatar b2z b2z - change - 15 Sep 2014
Labels Added: requirement
avatar b2z b2z - change - 15 Sep 2014
Labels Added: v1.x
Removed: v1.0
avatar b2z b2z - change - 15 Sep 2014
Labels Added: enhancement
avatar zero-24
zero-24 - comment - 30 Jan 2015

@b2z any more questions or problems here? I also would like to see the labels on github. Prefix ~ sounds ok for me (if we realy need one)

I think for theory we need to run a addStatusAsLabel function on the save action on JTracker as we can only change the Jissues status there.

Maybe a similiar thing that we have for the closed and open state?
https://github.com/joomla/jissues/blob/master/src/App/Tracker/Controller/Issue/Save.php#L100-118

Example code could be look like this:

    private function getLabelForStatus($issue_id)
    {
        switch ($issue_id)
        {
            case 1:
                $label = '~Open';
                break;
            case 2:
                $label = '~Confirmed';
                break;
            case 3:
                $label = '~Pending';
                break;
            case 4:
                $label = '~RTC';
                break;
            case 5:
                $label = '~Fixed';
                break;
            case 6:
                $label = '~Review by Maintainers';
                break;
            case 7:
                $label = '~Information Required';
                break;
            case 8:
                $label = '~Platform';
                break;
            case 9:
                $label = '~No Reply';
                break;
            case 10:
                $label = '~Closed';
                break;
            case 11:
                $label = '~Expected Behavior';
                break;
            case 12:
                $label = '~Known Issue';
                break;
            default:
                $label = '~Unknown Status';
        }

        return $label;
    }
private function addLabelToGitHub(...)
{
// let the github bot add it if needed
}

switch and ID --> Status based on: #318 (comment)

Some code is allready there for the RTC label (08be5c5) but it only run on a new commit. i think we should run our function on the issue save on Jissues.

avatar b2z
b2z - comment - 30 Jan 2015

@zero-24 nope, no questions here. Simply I do not have enough time as earlier to implement it. There are still more issues to fix and this one is not the prior one...

avatar zero-24
zero-24 - comment - 30 Jan 2015

Ok sorry @b2z Thanks!

avatar zero-24
zero-24 - comment - 30 Jan 2015

@b2z i hope you can have a look into: #598

avatar mbabker mbabker - unlabeled - 25 Nov 2016
avatar mbabker mbabker - unlabeled - 25 Nov 2016
avatar mbabker mbabker - labeled - 25 Nov 2016
avatar mbabker
mbabker - comment - 25 Nov 2016

Is there still interest in having statuses as labels? If so, someone care to take a stab at this?

avatar b2z
b2z - comment - 25 Nov 2016

If interest still there I will try to do it. BTW - what labels on GitHub already represent statuses on tracker, like RTC? Those should not be synced?

avatar brianteeman brianteeman - change - 9 Dec 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-12-09 17:40:37
Closed_By brianteeman
avatar brianteeman brianteeman - close - 9 Dec 2016

Add a Comment

Login with GitHub to post a comment