Success

User tests: Successful: Unsuccessful:

avatar dongilbert
dongilbert
13 Feb 2014

This PR updates the OAuth request scope to support private repos.

avatar dongilbert dongilbert - open - 13 Feb 2014
avatar mbabker mbabker - change - 13 Feb 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-02-13 17:12:54
avatar mbabker mbabker - close - 13 Feb 2014
avatar mbabker mbabker - reference | - 13 Feb 14
avatar mbabker mbabker - merge - 13 Feb 2014
avatar mbabker mbabker - close - 13 Feb 2014
avatar dongilbert dongilbert - head_ref_deleted - 13 Feb 2014
avatar elkuku
elkuku - comment - 13 Feb 2014

Just curious: What additional information do we get for our current project?
I'd prefer to have the "scope" as narrow as possible.
Can we make that a config option?

Could this "scare away" possible Joomla! CMS bug hunters ? :wink:

avatar dongilbert
dongilbert - comment - 13 Feb 2014

Not sure how a broad scope would scare away bug hunters.

Also, if you want to replace JoomlaCode with this, you'll need private issue tracking, since JC currently offers that.

I'm implementing this as our client issue tracker at work, and the repo scope is required so we can access the private repos that contain the code.

avatar elkuku
elkuku - comment - 13 Feb 2014

Well I mean, the first time you log in with your GitHub account you have to grant access to the application.
So if a possible bug hunter is been asked to give access to his/her private repositories he/she might get scared (note the smiley in the previous message)

I was about to ask of the use case and I feel quite proud of your implementation.

Would it be OK if we make this a config option ?

avatar dongilbert
dongilbert - comment - 13 Feb 2014

Sure, a config option is a reasonable compromise.

As for the implementation, there are some things lacking that I'll need to code up and contribute back, but nothing too major. The biggest hurdle right now is creating and commenting on issues while not having a GitHub account - we require that functionality.

avatar elkuku elkuku - reference | - 13 Feb 14
avatar dbhurley dbhurley - reference | - 13 Feb 14

Add a Comment

Login with GitHub to post a comment