Success

User tests: Successful: Unsuccessful:

avatar elkuku
elkuku
30 Jan 2014

Hide a checkstyle warning that might go into a separate file when expanding this

avatar elkuku elkuku - open - 30 Jan 2014
avatar elkuku
elkuku - comment - 30 Jan 2014

BTW: The checkstyle warning is here.
BTW2: This PR has been created by an external GUI as described here.


You may blame the J!Tracker Application for transmitting this comment.

avatar b2z
b2z - comment - 30 Jan 2014

Do you want us to test it? :) Such a small addition in the PR :smile:

BTW GitHub so nicely changed the UI. Love it.

avatar elkuku
elkuku - comment - 30 Jan 2014

You may test if the cli/tracker.php test checkstyle command now runs without errors :wink:

avatar b2z
b2z - comment - 30 Jan 2014

Hmm I do not have coding standards in build/phpcs/Joomla. Should I copy from joomla/coding-standards? BTW this folder is not in .gitignore.

avatar mbabker
mbabker - comment - 30 Jan 2014

It's a git submodule pointing at that repo. So when you clone this repo, that should get activated as well. If not, you might need to manually activate it (no idea how).

avatar b2z
b2z - comment - 30 Jan 2014

you might need to manually activate it (no idea how).

Yeah :D I also do not know ^_^

avatar elkuku
elkuku - comment - 30 Jan 2014

Just do a
git submodule init
git submodule update
that should check out the submodule ;)

avatar b2z
b2z - comment - 30 Jan 2014

Did it and now it works, but have many errors like:
1 | ERROR | End of line character is invalid; expected "\n" but found "\r\n"

Seems that running it on Windows gives them :(

avatar elkuku
elkuku - comment - 30 Jan 2014

This is why the Vagrant stuff errored on your system...
Seems like your IDE is converting line endings on import ?
Or the git client ?

BTW: Seems like the correct command to clone the repo would be git clone --recursive - should the readme be updated ?

avatar b2z
b2z - comment - 30 Jan 2014

Seems like your IDE is converting line endings on import ? Or the git client ?

Seems like git client, cause I have autocrlf = true in the config.

Seems like the correct command to clone the repo would be git clone --recursive

Why?

avatar elkuku
elkuku - comment - 30 Jan 2014

Why?

Because it will also clone the submodules :wink:

avatar elkuku
elkuku - comment - 30 Jan 2014

I have autocrlf = true in the config.

I believe you might set this also on a per repository basis if you really need it.

avatar b2z
b2z - comment - 30 Jan 2014

Because it will also clone the submodules

ok

I believe you might set this also on a per repository basis if you really need it.

Well I should try to set it to false for this repo and will see how it goes. But not today :)

avatar b2z
b2z - comment - 4 Feb 2014

Just cloned the repo with autocrlf = false. Will test it tomorrow.

avatar elkuku
elkuku - comment - 4 Feb 2014

This sounds more like a general issue... Maybe we can add this to #247 where the feature was introduced, or just open a new issue - and merge this one :wink:

avatar b2z
b2z - comment - 5 Feb 2014

Why do we need to open new issue? Sry I can't understand. But this now runs without an error. Merge!

avatar b2z b2z - change - 5 Feb 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-02-05 18:28:13
avatar b2z b2z - close - 5 Feb 2014
avatar b2z b2z - reference | - 5 Feb 14
avatar b2z b2z - merge - 5 Feb 2014
avatar b2z b2z - close - 5 Feb 2014
avatar b2z b2z - head_ref_deleted - 5 Feb 2014
avatar elkuku
elkuku - comment - 5 Feb 2014

All good then :wink:

avatar b2z
b2z - comment - 5 Feb 2014

Almost. Seems that first run on Travis has failed. But the second one is good.

avatar elkuku
elkuku - comment - 5 Feb 2014

Yeah well... It seems like Composer's error messages are often.... misleading ;)

When I change my local composer.json file requiring a higher PHP version than I have installed, I get the same strange errors.

So, We should mothball the PHP 5.3 test and look for a 5.5 one :tongue:

avatar b2z
b2z - comment - 5 Feb 2014

Yeap 5.3 is a history now :)

avatar elkuku
elkuku - comment - 5 Feb 2014

Add a Comment

Login with GitHub to post a comment