User tests: Successful: Unsuccessful:
Hide a checkstyle warning that might go into a separate file when expanding this
Do you want us to test it? :) Such a small addition in the PR ![]()
BTW GitHub so nicely changed the UI. Love it.
You may test if the cli/tracker.php test checkstyle command now runs without errors ![]()
Hmm I do not have coding standards in build/phpcs/Joomla. Should I copy from joomla/coding-standards? BTW this folder is not in .gitignore.
It's a git submodule pointing at that repo. So when you clone this repo, that should get activated as well. If not, you might need to manually activate it (no idea how).
you might need to manually activate it (no idea how).
Yeah :D I also do not know ^_^
Just do a git submodule initgit submodule update
that should check out the submodule ;)
Did it and now it works, but have many errors like:1 | ERROR | End of line character is invalid; expected "\n" but found "\r\n"
Seems that running it on Windows gives them :(
This is why the Vagrant stuff errored on your system...
Seems like your IDE is converting line endings on import ?
Or the git client ?
BTW: Seems like the correct command to clone the repo would be git clone --recursive - should the readme be updated ?
Seems like your IDE is converting line endings on import ? Or the git client ?
Seems like git client, cause I have autocrlf = true in the config.
Seems like the correct command to clone the repo would be git clone --recursive
Why?
Why?
Because it will also clone the submodules ![]()
I have
autocrlf = truein the config.
I believe you might set this also on a per repository basis if you really need it.
Because it will also clone the submodules
ok
I believe you might set this also on a per repository basis if you really need it.
Well I should try to set it to false for this repo and will see how it goes. But not today :)
Just cloned the repo with autocrlf = false. Will test it tomorrow.
Why do we need to open new issue? Sry I can't understand. But this now runs without an error. Merge!
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-02-05 18:28:13 |
All good then ![]()
Yeah well... It seems like Composer's error messages are often.... misleading ;)
When I change my local composer.json file requiring a higher PHP version than I have installed, I get the same strange errors.
So, We should mothball the PHP 5.3 test and look for a 5.5 one ![]()
Yeap 5.3 is a history now :)
All is green again https://travis-ci.org/joomla/jissues/builds/18293975 :)
BTW: The checkstyle warning is here.
BTW2: This PR has been created by an external GUI as described here.
You may blame the J!Tracker Application for transmitting this comment.