[#282] - Implement an event system in the GitHub hooks
- Closed
- 15 Jan 2014
- Medium
- Build: master
- # 282
- Diff
- joomla:eventSystem
- Success default The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Presently, there are hard coded checks in the ReceivePullsHook class to do custom processing for the joomla-cms repo which is not optimal in that we should not be hard coding this type of activity into our structure. To allow for a more dynamic solution, this pull implements the framework's Event package into the hook controllers and registers the dispatcher globally via the application object.
The other day I was thinking of adding onto the CLI app a method to trigger the hook controllers since those effectively can't be tested without the data payload. Or we actually write unit tests for our code, but who does that? :-D
| Labels |
Added:
enhancement
|
||
elkuku
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-01-15 15:33:47 |
I suppose that this cannot be tested? :)