avatar brianteeman
brianteeman
13 Dec 2013

Looks like the Recently Updated filter is not working correctly.
Andrew and I have both been commenting on #234 (perhaps only directly on github) but it is showing as last modified several days ago (perhaps the creation date) on jissues

avatar brianteeman brianteeman - open - 13 Dec 2013
avatar b2z
b2z - comment - 13 Dec 2013

Recently updated is working on the modified_date field:

ORDER BY a.modified_date DESC

So we need one more filter option like recently commented?

avatar brianteeman
brianteeman - comment - 13 Dec 2013

How does it decide that it is modified if a comment is not a modification?
Is it just recording modified on edits to the first comment? If so then that is useless. Why would we want that?

avatar b2z
b2z - comment - 13 Dec 2013

Just explored the code - a comment does not alter modified_date field. It only adds info into the activities table. As far as I can see modified_date is altered only during the status changes.

avatar b2z
b2z - comment - 13 Dec 2013

@brianteeman do you think that a comments should update modified_date and modified_by fields? What do others think about it?

avatar drmmr763
drmmr763 - comment - 13 Dec 2013

I feel like the issue and the issues comments are related, but not the
same. I also think that comments are activities, as are creating new issues
or editing issues. To me the proper thing to do would be to put everything
like new comments and updates to an issue all into the activities table,
and make that what we use for things like "recently updated". Perhaps
consider changing from recently updated to " recent activities". That
could include all the actions of comments, issue updates, and anything else
that happens.

On Friday, December 13, 2013, Dmitry Rekun wrote:

@brianteeman https://github.com/brianteeman do you think that a
comments should update modified_date and modified_by fields? What do
others think about it?


Reply to this email directly or view it on GitHub#273 (comment)
.

avatar brianteeman
brianteeman - comment - 14 Dec 2013

@drmmr763 for the issues I take the created date as related to the issue and modified date as related to the comments

@all for me ANY activity on the issue is an update (or modification)
You may blame the J!Tracker Application for transmitting this comment.

avatar b2z
b2z - comment - 14 Dec 2013

for me ANY activity on the issue is an update (or modification)

And from the speed perspective it's also a small win, because the query will be simple. Otherwise we should join over the activities table.

avatar b2z
b2z - comment - 15 Jan 2014

Thoughts on it?

avatar b2z
b2z - assign - 15 Jan 2014
Assigned to b2z
avatar KISS-Web-Design
KISS-Web-Design - comment - 15 Jan 2014

I agree that a comment should be an update to an issue, and therefore be reflected in any "latest" filter for activity, update or modification.

It's just what I expect to see from such filters, there could even be an "include comments" or "exclude comments" checkbox if this would help clarify what is being filtered.

avatar mbabker
mbabker - comment - 15 Jan 2014

+1. Last modified should be the last time anything associated with an item
is modified IMO. Joomlacode updates the modified date with every save
action basically, we should too.

On Wed, Jan 15, 2014 at 12:53 PM, Chris Jones-Gill <notifications@github.com

wrote:

I agree that a comment should be an update to an issue, and therefore be
reflected in any "latest" filter for activity, update or modification.

It's just what I expect to see from such filters, there could even be an
"include comments" or "exclude comments" checkbox if this would help
clarify what is being filtered.


Reply to this email directly or view it on GitHub#273 (comment)
.

avatar b2z
b2z - comment - 16 Jan 2014

Ok, most are for the comments affecting modified_date. Will start to implement then :sunglasses:

avatar b2z
b2z - comment - 23 Jan 2014

Testing it :)
You may blame the J!Tracker Application for transmitting this comment.

avatar brianteeman brianteeman - change - 10 Mar 2014
Status New Confirmed
avatar brianteeman brianteeman - change - 10 Mar 2014
Status Confirmed Pending
avatar b2z b2z - close - 10 Oct 2014
avatar b2z b2z - close - 10 Oct 2014
avatar b2z b2z - change - 10 Oct 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-10-10 06:33:04

Add a Comment

Login with GitHub to post a comment