enhancement v1.0
avatar betweenbrain
betweenbrain
26 Nov 2013

Steps to reproduce the issue

Click http://issues.joomla.org/tracker/joomla-cms/2523

Expected result

The issue

Actual result

0 RuntimeException
Invalid Issue

System information (as much as possible)

Additional comments

avatar betweenbrain betweenbrain - open - 26 Nov 2013
avatar mbabker
mbabker - comment - 26 Nov 2013

I always wondered why those RuntimeException messages popped up in our
error.log file.

On Tue, Nov 26, 2013 at 1:58 PM, Matt Thomas notifications@github.comwrote:

Steps to reproduce the issue

Click http://issues.joomla.org/tracker/joomla-cms/2523
Expected result

The issue
Actual result

0 RuntimeException
Invalid Issue

https://monosnap.com/image/4Fi8tXizrAkZAr09UjQk6SlmJ
System information (as much as possible) Additional comments


Reply to this email directly or view it on GitHub#228
.

avatar betweenbrain
betweenbrain - comment - 26 Nov 2013

Mystery explained. Should that indeed be an error page, or "that item has been closed" message?

avatar mbabker
mbabker - comment - 26 Nov 2013

If the issue isn't in the database (I don't see it on the tracker?) then it'll definitely throw an error page. I did a dump of everything but the users data when I merged the milestone PR from Andrew to the server, so a lot of data was taken with it.

avatar elkuku
elkuku - comment - 26 Nov 2013

So it's a feature ;)
Maybe the message could be a bit friendlier but hey - I prefer error messages to be as verbose as possible.
But for production we might just stick with the "invalid issue" message, without logging etc.

avatar betweenbrain
betweenbrain - comment - 26 Nov 2013

So it's a feature ;)

:laughing:

Since the goal is to make this application easily used, even by non-developers, I'd suggest something like

That issue does not exist, or the ID you typed is incorrect. Please try searching for the issue.

avatar b2z
b2z - comment - 27 Nov 2013

I would vote for: show a nice message to the user, write a verbose message to the log.

avatar elkuku elkuku - change - 27 Nov 2013
Status New Closed
Closed_Date 0000-00-00 00:00:00 2013-11-27 16:46:29
avatar elkuku elkuku - close - 27 Nov 2013
avatar elkuku elkuku - close - 27 Nov 2013
avatar betweenbrain
betweenbrain - comment - 27 Nov 2013

Nice

Add a Comment

Login with GitHub to post a comment