[#216] - Refactor site application
- Closed
- 16 Dec 2013
- Medium
- Build: master
- # 216
- Diff
- joomla:refactor-site
- Success default The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is about refactoring the controller classes and using the core DIC instead of our own bread. However nothing of the "DIC magic" using reflection classes and such has been applied yet.
I think the current execute method is far too complex as it not only instantiates the view and the model as also echoing the result of the views render method.
Child classes have pretty less to override.
So I moved the instantiation of the model and view to an initialize method that sets up the model and view based on the $defaultView property or the controller name.
So child classes can override this method and inject stuff to model and view classes. Note that the parent class must be called first.
class Foo extends AbstractTrackerController
{
public function initialize()
{
parent::initialize();
$this->model->setFoo('bar');
// ...
return $this;
}
}I also finished the renaming of the controller classes, which I started in 4e554f5, and apparently nothings blew ;)
But what currently is perventing us from the merge? From the code perspective I do not see any issues and if they exists then we will fix them :) It would be more harder to do it later...
I'm not the one making final decisions around here on everything, just enabling folks to develop on a highly visible project and updating a remote server 
I think the hesitancy is purely from the number of files touched. :)
It looks good here though and I can merge this and the related language unless anyone has a concern.
I am 
Can we merge it? It includes the vital functional changes in the controllers, so more it stays umerged more harder is to code new features :(