GitHub sync
avatar elkuku
elkuku
15 Nov 2013

If you edit an issue description text or a comment on GitHub, the text is not updated in JTracker.

I am not sure if there is a hook or if some kind of cron job is required here but this might be confusing if it's out of sync.

avatar elkuku elkuku - open - 15 Nov 2013
avatar elkuku elkuku - open - 15 Nov 2013
avatar mbabker
mbabker - comment - 15 Nov 2013

Have to look, but the comment and issue web hooks should be triggering on any insert/update action and passing the payload over. Could be as simple as something needing to be updated that fell out of sync in our code.

Edit 1

avatar mbabker
mbabker - comment - 16 Nov 2013

It isn't the hooks failing, they just aren't being called at all. Will need to read up on this to see if something with the hooks might have changed.

avatar b2z
b2z - comment - 16 Nov 2013

they just aren't being called at all

That's bad news :(

avatar mbabker
mbabker - comment - 16 Nov 2013

If the text of http://developer.github.com/v3/activity/events/types/ means what it says, especially in the case of the IssueCommentEvent, we've got a problem if these things are only being triggered on create now and not update.

Edit: Guess we could hook something up to http://developer.github.com/v3/issues/events/ to debug and see what all is actually being recorded.

avatar elkuku
elkuku - comment - 18 Nov 2013

http://developer.github.com/v3/issues/events/ - I think those do not refer to comments :(
But they are providing information we do not have ATM - especially the close event.. also referenced might be explored.

Oh and the framework API command for issues->events->get() is wrong... Is anybody actually using this stuff ??

avatar elkuku
elkuku - comment - 18 Nov 2013

Well, actually the API isn't wrong (phew..) but I don't get any comment information through the events, so - issue remains.

avatar b2z
b2z - comment - 19 Nov 2013

:( That's disappointing. Comments are the big part of the workflow...

avatar mbabker
mbabker - comment - 19 Nov 2013

I shot an e-mail off to GitHub a couple of days ago and did get a reply. From the text, I'm not sure if it is an intentional change or an issue they're working on. They did suggest if we have to go that route doing Conditional Requests to not kill our API rate limit if we have to go the route of a cron job or something to update us.

avatar mbabker
mbabker - comment - 20 Nov 2013

Got word back from GitHub. We're gonna have to handle updates without update events on the API for now.
You may blame the J!Tracker Application for transmitting this comment.

avatar elkuku
elkuku - comment - 2 Feb 2014

Should be fixed by a cron job running #291

avatar elkuku elkuku - close - 2 Feb 2014

Add a Comment

Login with GitHub to post a comment