bug v1.0
avatar brianteeman
brianteeman
13 Nov 2013

Every time you submit an issue two events are created and logged on the issue - see below

avatar brianteeman brianteeman - open - 13 Nov 2013
avatar brianteeman brianteeman - open - 13 Nov 2013
avatar elkuku
elkuku - comment - 13 Nov 2013

You mean the "Open" event ? Confirmed.
I would suggest to not display it in the issue view anyway..
The double creation is probably caused by the table class... who's first ? ;)

avatar b2z
b2z - comment - 13 Nov 2013

The double creation is probably caused by the table class... who's first ? ;)

Yes it is. We should decide how to fix it:

  1. Remove store action from the IssueModel;
  2. Remove post actions from the IssueTable;

I am voting for second option, because IssueTable class should handle only methods which are related to the issues table. Any post actions are ugly, leave them to IssueModel.

avatar b2z
b2z - comment - 14 Nov 2013

@elkuku @mbabker your votes?

avatar elkuku
elkuku - comment - 14 Nov 2013

My vote goes to
1.a Comment out the store action in the model for now to fix this annoying bug and put a @todo on it.

Then think about a more general solution to implement 2 on the long run.

I played with a method in the hooks base controller addActivityEvent that accepts the needed parameters for an "event" in its parameters.
Maybe we can put something like this into a model and access it from within the other models ?

If you would like to implement it right away, and @mbabker has no objections, then, of course, go for it ;)

avatar b2z
b2z - comment - 14 Nov 2013

Currently too many issues we have. Agree to comment it out under todo.

avatar - close - 14 Nov 2013
avatar b2z b2z - close - 14 Nov 2013
avatar mbabker
mbabker - comment - 20 Nov 2013

So I just reimported the full joomla/jissues tracker on the site re-installing to get the milestone data in, the get project command is still inserting 2 open events.
You may blame the J!Tracker Application for transmitting this comment.

avatar b2z
b2z - comment - 20 Nov 2013

Yeap, you need to comment out Activity creation in the Get Issues and mark it as @todo.

avatar elkuku
elkuku - comment - 20 Nov 2013

True... go for it @b2z , while you're at it: The close action should also be commented out, as it currently also generates two close events..

avatar b2z b2z - reference | - 21 Nov 13
avatar b2z
b2z - comment - 21 Nov 2013

Just pushed the commit to fix two open events.
@elkuku interesting, but I do not see in the IssuesTable any code related with the close event. How they can be doubled?

avatar elkuku
elkuku - comment - 21 Nov 2013

No that's a different beast... Currently this piece of code generates a "close" event - but since the "actor" is missing here, it's anonymous :(
So, only the get events CLI task is able to generate a proper "close" event - or a hook ;)
We have to really think this through how we handle those events...

avatar b2z
b2z - comment - 22 Nov 2013

So if it will be commented out everything will work fine?

Add a Comment

Login with GitHub to post a comment