v1.0
avatar brianteeman
brianteeman
13 Nov 2013

Steps to reproduce the issue

Submit a new item without entering a build.

Expected result

Expect a big message at the top near the submit button saying you need to enter a build

Actual result

nothing happens but if you scan the entire page you will spot a tiny error message by the build field

Additional comments

personally I would create some sort of message area similar to the cms

avatar brianteeman brianteeman - open - 13 Nov 2013
avatar brianteeman brianteeman - open - 13 Nov 2013
avatar b2z
b2z - comment - 13 Nov 2013

personally I would create some sort of message area similar to the cms

These shows up when a check is failed on the server side.

you will spot a tiny error message by the build field

May be make them more visible, like adding red background and etc?

avatar mbabker
mbabker - comment - 13 Nov 2013

He does have a point about having messages in a designated container that's clearly visible instead of in small areas scattered on the page.

avatar brianteeman
brianteeman - comment - 13 Nov 2013

Its fairly standard practice to do it that way

avatar betweenbrain
betweenbrain - comment - 13 Nov 2013

Shouldn't there be a client-side validator preventing the form from even being submitted if required information is not present? Or, do I misunderstand the issue?

avatar brianteeman
brianteeman - comment - 13 Nov 2013

The issue is where the notification is on screen that you have to complete a field

avatar elkuku
elkuku - comment - 13 Nov 2013

I would suggest an area "close to" the button that you are clicking to submit, that gets "tainted red" or something if there are validation errors (or the button itself).

BTW, the CMS has similar issues when there are validation errors in a tab that does not have the focus - how is that handled ?

avatar b2z
b2z - comment - 13 Nov 2013

IMO that's a standard to have client-side JS validation errors near the incorrect fields.

avatar elkuku
elkuku - comment - 13 Nov 2013

Yes, but those errors might not be "visible" when the user actually "clicks" the submit button, so apparently "nothing happens".

avatar brianteeman
brianteeman - comment - 13 Nov 2013

Which is exactly what I observed.

But it is incredibly easy to do blind usability testing to prove my point

avatar betweenbrain
betweenbrain - comment - 13 Nov 2013

IMO that's a standard to have client-side JS validation errors near the incorrect fields.

Agreed. http://jquery.bassistance.de/validate/demo/ is a good exmaple.

Would something like the following help?

screenshot - 11132013 - 04 02 24 pm

avatar b2z
b2z - comment - 13 Nov 2013

I think that @brianteeman propose the following:

  1. Make errors more visible.
  2. Show additional error on the top that form is invalid.

Correct?

avatar brianteeman
brianteeman - comment - 13 Nov 2013
avatar b2z
b2z - comment - 15 Nov 2013

@brianteeman would it be enough or we also need big error message on the top?

untitled

avatar brianteeman
brianteeman - comment - 15 Nov 2013

I still think we need the big message at the top myself. I just would never see it if it was just over on the right and potentially above or below the fold

avatar b2z
b2z - comment - 15 Nov 2013

@brianteeman this will be good?
error
The problem is that I can't make this message translatable, because it's inside the JS. The only way to translate it is to place it inside the div, but this way it will stay there permanently :)

avatar betweenbrain
betweenbrain - comment - 15 Nov 2013

Just shooting blind here... but can the error message be generated by inline JS with the message created by PHP?

avatar elkuku
elkuku - comment - 15 Nov 2013

There are other areas where translatable strings are used in JavaScript files.
Let's first worry about how and where to display the validation messages in a way that they are visible.
We'll then find out how to translate them - I promise ;)

I believe the red message box stating that there are invalid fields is pretty neat.

avatar b2z
b2z - comment - 16 Nov 2013

Well if @brianteeman agree I will push the changes then :)

avatar b2z
b2z - comment - 16 Nov 2013

Seems that @brianteeman ok with it. Silence means yes ?

avatar - close - 16 Nov 2013
avatar brianteeman
brianteeman - comment - 16 Nov 2013

@b2z sorry I was taking some time offline. Your proposal is great.

avatar b2z
b2z - comment - 16 Nov 2013

ok ;) it was pushed already ?

avatar brianteeman
brianteeman - comment - 16 Nov 2013

I saw but thought it was polite to reply - and I try to be polite

Add a Comment

Login with GitHub to post a comment