CSS issue
avatar javigomez
javigomez
13 Nov 2013

I just noticed that the "open" link has a padding of 120px causing the link to extend vertically like the following image shows (MacOS Maverick on Chrome 31):
screen shot 2013-11-13 at 16 51 01

The padding that is affecting the link is this:
screen shot 2013-11-13 at 16 52 05

avatar javigomez javigomez - open - 13 Nov 2013
avatar javigomez javigomez - open - 13 Nov 2013
avatar javigomez
javigomez - comment - 13 Nov 2013

Same happens with other links:

screen shot 2013-11-13 at 17 00 54

avatar elkuku
elkuku - comment - 13 Nov 2013

This is a really ugly issue... If you have the chance to try the debug mode - it's much more obvious there...

Have a look at: https://github.com/joomla/jissues/blob/master/templates/tracker/issue.index.twig#L17-20

We have that affix thingy and the top bars - it really needs a CSS/JS expert to fix this.

avatar b2z
b2z - comment - 13 Nov 2013

Yeah we need some CSS/JS expert to check all our frontend code. Anyone? ;)

avatar elkuku elkuku - reference | - 14 Nov 13
avatar elkuku
elkuku - comment - 14 Nov 2013

So I did "something" - it should be noted however, that I don't like designing at all, so please improve.
I changed the target element to the containing div - applying a "nice" border... now it looks like this:
j tracker bugs 2013-11-14 17-11-19

If you scroll down, the padding remains... ugly ?

j tracker bugs 2013-11-14 17-11-42

Thoughts ?

BTW: This should display the same in FireFox, Chrome etc. - Tested on Linux with latest FF, Chrome and Opera.

avatar b2z
b2z - comment - 15 Nov 2013

Can someone explain me what is the purpose of this target :blush: ?

avatar elkuku
elkuku - comment - 15 Nov 2013

The idea is to have the browser "jump" to the part of the page you are interested in.
e.g. on GitHub
#182 (comment)
edit GitHub shortens those links automagically... the link is https://github.com/joomla/jissues/issues/182#issuecomment-28419082
this would be on our thingy
http://issues.joomla.org/tracker/jtracker/182#event-6339

The ugly gap is necessary because of those three top bars we have (2 1/2 maybe.. one affixed)
I would like to, again, suggest that we switch to a modern "flat" theme that contains only one fixed top bar which, I guess, would also solve this issue.

Well, as the issue reporter stated, the padding is "wrong" - so what would be right ?

avatar b2z
b2z - comment - 15 Nov 2013

Ah that's what it meant :) OK!

I would like to, again, suggest that we switch to a modern "flat" theme that contains only one fixed top bar which

I am also for it :+1: But @mbabker against ;)

avatar mbabker
mbabker - comment - 15 Nov 2013

I'm not against it at all, but I think there should be some consistency between the Joomla network of sites. IMO, it's bad user experience to have completely different templates on each of our sites. Truth be told, I'd rather the rest of the network catch up with the PLT and use our Bootstrapped template. It has its quirks, but visually it just feels better than the version used on our 2.5 based sites.

avatar elkuku
elkuku - comment - 15 Nov 2013

I really like the template the docs folks implemented on http://docs.joomla.org ;)
So, I think the developer sites and the sites which are supposed to be "working sites" (as opposed to "PR", showcase or whatever needs a "catchy design" .... ) may have some extremely simple (I bet they will be) so - let's be the first to implement it :wink:

avatar elkuku
elkuku - comment - 15 Nov 2013

OH WAIT - I forgot to say: I do not want to be the one to actually DO it...
I just :+1: it ;)

avatar b2z
b2z - comment - 15 Nov 2013

OH WAIT - I forgot to say: I do not want to be the one to actually DO it...

I think we will find someone ;)

avatar mbabker
mbabker - comment - 16 Nov 2013

So I'm thinking about it a bit. Truth be told, there's a few options:

  • Keep the current layout and update the CSS to Bootstrap 3 (there's the flat design thing mixed in with my desire for some consistency)
  • Leave things alone and make the current template work
  • Say "screw uniformity" and go back to the roots of this project and just do our own thing template wise

Thoughts?

avatar dbhurley
dbhurley - comment - 16 Nov 2013

Step 1: Keep current layout - it's similar to all other J sites but update to BS3.
Step 2: Begin working on a new template layout formatted to take full advantage of all aspects brought in from Step 1 above.

I ignore the second point above :)

avatar b2z
b2z - comment - 16 Nov 2013

@dbhurley sounds like a plan :)

avatar elkuku
elkuku - comment - 16 Nov 2013

Change the current layout and go with "uniformity" - as in docs.joomla.org - which is meant to be used by developers and also "average users" - just Bootstrap-3-Itâ„¢

avatar b2z
b2z - comment - 2 Nov 2014

Partially I fixed it via d22e17e. Here is the CSS applied (was found on Stackoverflow):

:target:before {
display: block;
content: " ";
margin-top: -100px;
height: 100px;
visibility: hidden;

It will work within the page, but if you will try to open the page directly with the target in a new window it still will fail. I did not find any "normal" solution to fix it. Will close this issue for now. If someone will find how to fix it completely please issue a PR. Thanks.

avatar b2z b2z - close - 2 Nov 2014

Add a Comment

Login with GitHub to post a comment