[#176] - Validation issues
- Closed
- 15 Nov 2013
- Medium
- Build: master
- # 176
Some things need to get cleaned up with the validation rules IMO. Pull requests aren't merging into the app anymore, these being the common reasons:
- The title min length is 15 chars.
- The title max length is 50 chars.
- A build is required.
Title should match exactly what GitHub allows via the site here in terms of lengths. Build can be handled by defaulting to the destination branch in the hooks.
At https://github.com/joomla/jissues/blob/framework/src/App/Tracker/Controller/Hooks/ReceivePullsHook.php#L118 add in $data['build'] = $this->data->base->ref; to that array.
A little bit confusing to have branch name as a build, but if we do not have any other option then it's ok.
On Joomlacode, I often put in 'master' for the build to indicate the current master. So it would either be '2.5.x', 'staging', or 'master' when coming through GitHub.
Did not know that. Then the only problem now how to know min-max length for the title? I googled around and did not found anything...
how to know min-max length for the title?
We might abuse a bit and just try out...
jtester/tests#26 - Title length 1
jtester/tests#27 - Title length 100
jtester/tests#28 - Title length 200
I wouldn't go any further here but I don't think there is any "visible" limit on their side...
Well :) One space was missed by me
I've deployed the latest changes to the server, we'll see what happens now.
On joomla/joomla-cms#2508 still got a Some characters are not allowed in the title. message.
Oh my :) It's because of the exclamation mark. We should add it too of course.
Cool - I'll deploy it tonight
Sounds silly, but the next char that comes to my mind is a ? ....
I wish there was somewhere that their validator was posted.
FYI latest code is deployed.
Everything is ok?
Sounds like we need to make a test issue trying to pass all the keyboard into the title
I was talking about the project with the folks of the german http://www.joomla-bugs.de/ throwing around crazy ideas about a multi-lingual tracker.... so, those Ä, ä , Ö, ö... and of course the ß --- not talking about those chinese or even russian characters --- should be included (see: jtester/tests#30)
Hmm, currently our regex in the table class supports Unicode chars:
'/^[\w\pN\pL\pM\-.,()\[\]\'"\+_@&$#%!: ]+$/u'
But JS is not:
/^[a-z0-9\-.,()\[\]'"+_@&$#%!:\s]+$/i
I am not a prof in regex
[^\u0000-\u0080]
If not we will need some external library to achieve that.
Which brings up the interesting question if it might be possible to have one rule "provider" for both client and server side validation.
I was about to say that :-)
Sent from my Android =;)
On Nov 14, 2013 2:58 PM, "Dmitry Rekun" notifications@github.com wrote:
Well I just started #210 https://github.com/joomla/jissues/issues/210and it allowed all the chars... Seems we do not need to filter title at all?
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/176#issuecomment-28517193
.
Hehe :) Will post a fix tomorrow
-
Should be fixed. If not please leave a note here
I finally got around to deploying the latest up, so we'll see how it all goes.
Agree about title. Anyone knows allowed values? :)
For example?