enhancement upstream dependency Success

User tests: Successful: Unsuccessful:

avatar elkuku
elkuku
6 Nov 2013

Nothing is entirely bad... not even Twitter.... while I really hate to tweet, or read other peoples tweetings, the Twitter family produced some really decent stuff along the way.
You know Bootstrap ? well... here is

bower_230

From their web site:

Bower is a package manager for the web. It offers a generic, unopinionated solution to the problem of front-end package management

Turns out that all our external dependencies are installable using this bower thingy, so - why not ?

It can also output a nice dependency tree, check for new versions, etc.:

$ bower list
bower check-new     Checking for new versions of the project dependencies..
jissues#1.0 /home/elkuku/repos/jissues
├── blueimp-tmpl#2.4.0
├─┬ bootstrap#2.3.2 (latest is 3.0.1)
│ └── jquery#1.9.1 (2.0.3 available)
├─┬ bootstrap-switch#v1.8 incompatible with v1.8
│ └── jquery#1.9.1 (latest is 2.0.3)
├── jquery#1.9.1 (latest is 2.0.3)
├── jquery-validation#1.11.2
└── markitup#1.1.14

Not sure what this incompatible message means - so far it seems to work..

$ bower list --paths
{
  "blueimp-tmpl": "vendor/blueimp-tmpl/js/tmpl.js",
  "bootstrap-switch": "vendor/bootstrap-switch/static/js/bootstrap-switch.js",
  "bootstrap": [
    "vendor/bootstrap/docs/assets/js/bootstrap.js",
    "vendor/bootstrap/docs/assets/css/bootstrap.css"
  ],
  "jquery-validation": "vendor/jquery-validation/jquery.validate.js",
  "jquery": "vendor/jquery",
  "markitup": [
    "vendor/markitup/markitup/jquery.markitup.js",
    "vendor/markitup/markitup/sets/default/set.js",
    "vendor/markitup/markitup/sets/default/style.css",
    "vendor/markitup/markitup/skins/simple/style.css"
  ]
}

I also think we should organize our customizations into a common folder.

Maybe

www
├─┬ jtracker
│ └── XYZ-script - The JTracker customization
├─┬ vendor
│ └── XYZ-script - The external script

How does that sound ?

Since this PR removes all the external scripts from our code base, developers would have to install bower, or install the external scripts manually.

Do windows users maybe have concerns here ?

avatar elkuku elkuku - open - 6 Nov 2013
avatar elkuku elkuku - open - 6 Nov 2013
avatar b2z
b2z - comment - 7 Nov 2013

Wow that's a nice addition. I would go with

www
├─┬ jtracker
│ └── XYZ-script - The JTracker customization
├─┬ vendor
│ └── XYZ-script - The external script

I do not think that on Windows there will be a problem, but I will test ;)

avatar mbabker
mbabker - comment - 7 Nov 2013

:+1:

avatar elkuku
elkuku - comment - 7 Nov 2013

Glad you like it ;)
BTW, I'm really new to Bower, just discovered it yesterday by reading this interisting article (nice intro) - So there may be errors or things that might be improved - just playing :)

@b2z could you take a look at /www/jtracker/markitup/* and see if anything in there is ok or might better come from the vendor dir ?

On Windows: I just want to be sure that everybody is fine... since it depends on node and I recently watched a video where the guy said something like:
"Node on Windows isn't as good as it could be (...) but Windows is very important - just like PHP..." (laughing)

avatar b2z
b2z - comment - 7 Nov 2013

Everything looks ok in /www/jtracker/markitup/*.

avatar b2z
b2z - comment - 7 Nov 2013

As I said, no problem running Bower on the Windows. Awesome :+1:

avatar elkuku
elkuku - comment - 7 Nov 2013

So there is now a Documentation page listing our external dependencies - auto generated, of course :wink:

avatar mbabker
mbabker - comment - 8 Nov 2013

Let's do it!

avatar mbabker mbabker - reference | - 8 Nov 13
avatar mbabker mbabker - merge - 8 Nov 2013
avatar mbabker mbabker - close - 8 Nov 2013
avatar - close - 8 Nov 2013
avatar elkuku elkuku - head_ref_deleted - 13 Nov 2013

Add a Comment

Login with GitHub to post a comment