enhancement v1.0 Success

User tests: Successful: Unsuccessful:

avatar b2z
b2z
1 Nov 2013

This is the second part of #48 ? Fixed a couple of bugs and made some code optimization.

avatar b2z b2z - open - 1 Nov 2013
avatar b2z b2z - open - 1 Nov 2013
avatar b2z
b2z - comment - 1 Nov 2013

A question raised - during implementation I have commented out the GitHub's new issue submit feature and made only local submissions. But these new issues did not show on the issues list of the project though they exists in the issues table as well as activities. Is it a bug? And what is the point to allow the submissions without the GitHub authorization (I mean this one)?

avatar elkuku
elkuku - comment - 2 Nov 2013

And what is the point to allow the submissions without the GitHub authorization (I mean this one)?

The idea here is to allow "projects" that are only managed in JTracker but not in GitHub (e.g. a security tracker)

But these new issues did not show on the issues list of the project though they exists in the issues table as well as activities. Is it a bug?

I remember that the issue_id for new issues is retrieved from GitHub while for "non GitHub projects" it must be generated (I believe this is still a @todo :wink: )

avatar b2z
b2z - comment - 2 Nov 2013

Thanks @elkuku, now it's clear.

avatar b2z
b2z - comment - 2 Nov 2013

So :) Good to merge? ;)

avatar mbabker
mbabker - comment - 2 Nov 2013

Code wise I don't see why not. Unfortunately I haven't pulled it down to test, but it reads well.

avatar b2z b2z - close - 3 Nov 2013
avatar b2z b2z - reopen - 3 Nov 2013
avatar b2z
b2z - comment - 7 Nov 2013

@elkuku what do you think? Good to merge?

avatar mbabker
mbabker - comment - 7 Nov 2013

On your demo server, David and I noted a small issue. On the closed filter, the Date Closed column is hidden, but visible on the open filter. Still checking out the rest, but looking sharp :+1:

avatar b2z
b2z - comment - 7 Nov 2013

Hehe, silly me. This code is the reverse problem:

if ($('#filter-status').val() == 10) {
        $('.date-closed').hide();
};

Should be:

if ($('#filter-status').val() == 1) {
        $('.date-closed').hide();
};

Thanks will fix it :)

avatar elkuku elkuku - reference | 64b9773 - 7 Nov 13
avatar elkuku elkuku - merge - 7 Nov 2013
avatar elkuku elkuku - close - 7 Nov 2013
avatar - close - 7 Nov 2013
avatar b2z
b2z - comment - 8 Nov 2013

Yeah :sunny: We are moving forward :sunglasses: I still hope to release v1.0 in December :)

avatar b2z b2z - head_ref_deleted - 8 Nov 2013

Add a Comment

Login with GitHub to post a comment