[#153] - Process labels in hooks classes
- Closed
- 19 Oct 2013
- Medium
- Build: framework
- # 153
- Diff
- joomla:hookLabels
- Success default The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The specific implementation right now is for a specific label on the CMS repo in terms of adding a label and updating GitHub. The same concept can be used for other labels on other repos, probably with a better configuration and more abstract code, but this got me started.
The whole idea came from someone pointing out they'd like a way to filter pull requests by a target branch since you can't do it with GitHub natively.
Labels should be getting processed for both repos with the hooks on labels that already exist on an item. If not, there's a bug.
Looks like a nice idea, thanks for clarifying ;)
-
One question here... who do you think should delete the merged branches ? The person who merges the PR or the one who opened it ?
If the origin branch is in the main repo, it doesn't matter since the branch is merged.
OK, it just feels like "deleting someone else's branch"... never mind.
Looks good ;)
I wasn't actually able to test it since it is "joomla/joomla-cms" only - why ?