Feeling Lucky
[#1062] - Allow the jbs group to see and change the labels and milestones using the bot
- Fixed in Code Base
- 17 Jun 2019
- Medium
- Build: master
- # 1062
- Diff
- zero-24:allow_labels_jbs
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue joomla/joomla-cms#25233
Summary of Changes
Allow the jbs group to see and change the labels and milestones using the bot
Testing Instructions
After this change the groups with edit permission can change the labels and milestones. Before only admins could have done that.
| Title |
|
||||||
| Title |
|
||||||
zero-24
- comment
- 17 Jun 2019
Yes just updated the code and texts.
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-17 17:59:18 |
| Closed_By | ⇒ | mbabker |
The save and submit controller actions need to be checked for ACL as well (and anything they use, i.e. the model or table classes). Just on a quick check there's this block which might mean there are more checks to update.
Also, as is this is giving both label and milestone access; not sure if that's what you're intending since the title and description only talk about labels.