Feeling Lucky
[#1051] - [Auto Labels] Make sure only NPM dependencies get tagged
- Closed
- 19 Feb 2019
- Medium
- Build: master
- # 1051
- Diff
- zero-24:patch-1
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Make sure only external NPM dependencies get tagged as NPM Dependency Changed
Testing Instructions
- Please check: joomla/joomla-cms#23936
- No NPM dependencies ins included in that patch.
- throw the PR against the current code and the proposed code.
zero-24
- comment
- 19 Feb 2019
Ok didn't know that as i would our code not call an npm dependencie but by your definition the current code here makes more sense. Closing here. Thanks
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-19 15:12:19 |
| Closed_By | ⇒ | zero-24 |
mbabker
- comment
- 19 Feb 2019
Maybe the label text should change to NPM Resource Changed or something if "dependency" is going to be misleading. I basically just copied the Composer label and changed "Composer" to "NPM".
zero-24
- comment
- 19 Feb 2019
Yes NPM Resource Changed sounds good to me. Should i do an PR or would you like to directly commit it?
mbabker
- comment
- 19 Feb 2019
I've changed the label on the CMS repo and committed the change in the listener here.
zero-24
- comment
- 19 Feb 2019
Thanks
The intent wasn't to tag only vendor changes, but rather everything that relates to NPM resources. If this is going to be an issue then the
build/media_sourcedirectory should just be removed in full because that vendor directory has basically nothing in it in relation to what the full dependency tree is.