Feeling Lucky
[#1026] - Use PHPCS 2.x ruleset
- Fixed in Code Base
- 24 Jun 2018
- Medium
- Build: master
- # 1026
- Diff
- joomla:jphpcs-2
- Success continuous-integration/travis-ci/push The Travis CI build passed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Migrates to PHPCS 2.x ruleset
- Expands line length to 250 characters
- Fixes most issues found by sniffer
- Sets allowed fail count due to upstream bugs checking tab count in closures
Testing Instructions
PHPCS command still runs
mbabker
- comment
- 24 Jun 2018
The bulk of the failures are related to joomla/coding-standards#230, the 7 from TotalActivity.php are because I still have commented code there. So, we can't completely fix them all unless we completely ignore the Joomla.ControlStructures.ControlStructuresBrackets.SpaceBeforeBrace sniff.
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-24 21:50:30 |
| Closed_By | ⇒ | elkuku |
elkuku
- comment
- 24 Jun 2018
I guess the phpcs2-test branch can also be deleted?
mbabker
- comment
- 24 Jun 2018
Yep.
TBH I am not quite sure about the added?
ALLOWED_FAIL_COUNThere since there are still fixable errors I believe, but we are getting closer to phpcs V3