a minor issue

the message container is outside the container div.

@andrepereiradasilva this PR is for content of Versions modal. The alert message is loaded from the template, via the iframe, not the view modal.php
At the end of all modals changes, i will add a few css changes to existed container-popup class, to add media query (too high padding on mobile), so it could be seen at this moment to add a declaration for alert message, when inside a (iframe) modal ;-)

I have tested this item successfully on 557ad29

works as described

I have tested this item successfully on 557ad29

RTC

Cloud you explain why you removed the h3 and the Text "COM_CONTENTHISTORY_MODAL_TITLE" seems to me lost of semantic and information

@rdeutz the modal.php file for version is loaded as content for modal-body (not used in a page content).
And, if you look in description of this PR, there was an issue with dupplicated title for the modal: one in the modal header, and one h3 tag in the modal-body.
I don't see why you think of a lost of semantic and information ?... (information in modal header, and h3 not as its place in a content body of a modal, where this one is not useful)
I think this was making sense when using mootools modal, but no more sense since using bootsrap modal ;-)

Good spot @rdeutz
Because this is using a layout for the ISIS template it wasnt needed but when you check hathor there now is no title.

Removing RTC

Remove RTC

Ok i see!

So, other modals already have this issue on hathor (user select...) and so needs an override for Hathor!
I will see to add the override, and then to do the same for other modals i will update ;-)

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

@rdeutz @brianteeman @andrepereiradasilva , i've created in Hathor Html folder, the override for com_contenthistory/history/modal.php (none override for this component before).
So, could you then test again this PR with Hathor template ?

Thanks! ;-)

Before Patch with Hathor admin template (3.5.1):

After Patch with Hathor admin template:

Note: no change for Isis, so tests still available. ;-)
Note Hathor: using Hathor css classes table and title

tested. test still a success for me.

It works here, but, for hathor, maybe some changes are still necessary as h1, h2 and h3 ave weird font-sizes:
h1 (font-size: 1.4em;),
h2.modal-title (font-size: 1.8em;) // used here.
h3 (font-size: 1.4em;)

Also the filterbar is unreadable.
I tested this which is much better imho:

body.contentpane .modal-body #filter-bar {
    font-size: 1.1em;
}

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

@infograf768 i have changed modal title to this:

<div class="modal-header">
    <h3><?php echo JText::_('COM_CONTENTHISTORY_MODAL_TITLE'); ?></h3>
</div>

Also the filterbar is unreadable.
I tested this which is much better imho:

Do you mean that when fixing core modal.php file, i have to fix Hathor css issues too ?...
In adding the missing Hathor override for com_contenthistory, i have just adapt to existing Hathor classes.

Should i add css for button inside modals, and to fix table border (missing top) in css too ? (EDIT: Done!)
About Hathor css, should use less ? What about no less rtl ?
So... waiting for some advices if i should set css for modals content, and how to change css in Hathor (less, rtl ?...) (EDIT: it's ok, did it!)

Thanks!

I have tested this item successfully on c32c2a1

tested hathor seems ok for me

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

@andrepereiradasilva Sorry for last commits (i will have to re-install my Github app (crashed after update to os el capitan...)) but added some last Hathor changes, this time by introducing a new modal-buttons class, and fixing missing top border for adminlist when in modal.

_{Preview of current PR on Hathor}

This way, the html structure is logic for Hathor (not usage of fieldset filter-bar to be able to have a decent table border), and a little improvement of buttons.
So, @andrepereiradasilva a new test required on Hathor, as tests reset...

@infograf768 could you check then with Hathor, as i think it could be good now (addition of new css class for modal-buttons, and a bit more readable!)

Thanks all for testing!

Note 1: No change for core (so, on Isis) so tests on Isis still valids.

Note 2: when this PR for Versions modal will be accepted (i started with this one, as the one with the most minor issues), i will prepare a PR with other modals (modal.php) loaded inside a modal iframe. Not a lot of issues for others, but good to set all modal.php on the same way. Confirmation and validation for Hathor override proposed here is welcome, as it will be needed to redo all the other modal.php overrides in Hathor, all not nice... c/c @rdeutz @brianteeman

I have tested this item successfully on c9b9f1a

I have tested this item successfully on c9b9f1a

RTC thanks