[#9994] - Regression: com_modules batch positions and hathor client select
- Fixed in Code Base
- 20 Apr 2016
- Medium
- Build: staging
- # 9994
- Diff
- andrepereiradasilva:regression_module
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Solves regressions:
- In batch modal the positions are not selected based on the client id
- In hathor we can't select the client in modules view (it always goes back to Site)
Testing Instructions
- Apply this patch in latest staging
- Do a batch with client site in modules (check the positions in batch are from site templates)
- Do a batch with admins site in modules (check the positions in batch are from admin templates)
- Change the admin template to hathor. Try to change between client and admin modules.
Note: you can check that without the patch they are incorrect.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
@andrepereiradasilva Sorry, mistake in my post above, I mean the dropdown changes back to "Site".
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9994.
@andrepereiradasilva But I think you know what I mean. It's only the dropdown value changing back erroneously, not the displayed modules list.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9994.
I have tested this item 
successfully on 669b08a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9994.
brianteeman
- | Category | ⇒ | Modules Templates (admin) |
I have tested this item successfully on 99866ab
Issue confirmed: before patch, client filter always set back to "site" and no batch possible on admin modules, in Hathor template.
On Isis, all is working well before and after patch.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9994.
I have tested this item successfully on 99866ab
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9994.
| Status | Pending | ⇒ | Ready to Commit |
Good find. For 3.5.2
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9994.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-20 11:24:47 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
@andrepereiradasilva Testing instructions are IMO not precise.
In fact we can select the admin site, i.e. the modules which are shown are the admin ones, only the dropdown value changes back to "Administrator".
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9994.