[#9967] - updated rating stars to cleaner look.
- Closed
- 25 Aug 2016
- Medium
- Build: staging
- # 9967
- Diff
- N6REJ:ratingStar
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Updates rating stars to a cleaner look.
Testing Instructions
create an article in the front end with voting enabled.
look at stars and notice they are not clearly defined especially on dark background.
apply patch.
notice voted and non-voted stars are much cleaner.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Plugins Templates (site) |
Yellow looks good on both light and dark background, but blank needs to be lighter to be visible on dark background. Although even in that case it won't be visible on some (grey) backgrounds.
Downloaded images from GitHub are 1.1~1.3 KB each. Can be optimized to 200-300 B.
I'm also wondering whether or not the circle needs to be changed to a star. That said, I'm suggesting these:
Why not using icomoon? icon-star(-2/-empty)
@SharkyKZ both those look nice...
@bembelimen is the icon-star in the joomla set already?
@N6REJ See https://docs.joomla.org/J3.x:Joomla_Standard_Icomoon_Fonts for the currently used pack.
Unless it's optional or overridable, IcoMoon inside a plugin would cause difficulties for those using newer templates without IcoMoon.
That being said, you probably can't just change the image to a CSS effect using IcoMoon. The current images can be overriden by templates plus templates may or may not implement the Icomoon set. So if you change this to the IcoMoon stars, you can probably break sites.
Im a little confused - your screenshot for "before" shows circles but I always have stars
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9967.
He's using a custom template. Joomla has circles by default, but Protostar has overrides with stars. Circles do need a cleanup.
Circles do need a cleanup.
So this PR changes the circles to a star but the PR says it is giving stars a cleaner look
it showed circle(ish) but the class and file name is stars... I'll take a closer look at this this weekend.
Showing circles only when I choose Beez template. Already stars in Protostar template.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9967.
I have tested this item
Tested successfully. Must check in Beez3 template.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9967.
I have tested this item
Tested Successfully in a Beez3 template.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9967.
I have tested this item
successfully tested only in Beez3 template.
Thanks @gunjanpatel for updating actual information.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9967.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Labels |
Removed:
?
|
||
| Category | Plugins Templates (site) | ⇒ |
| Labels |
Added:
?
|
||
I'm removing the RTC label here for now whilst we await clarification from Troy here. I think this is ok...
| Status | Ready to Commit | ⇒ | Information Required |
| Labels | |||
| Labels |
Removed:
?
|
||
| Category | ⇒ | Templates (site) |
@N6REJ could you please respond or this will be closed in a few weeks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9967.
As there has been no response from @N6REJ I am closing this. It can always be reopened if updated
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9967.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-25 12:59:17 |
| Closed_By | ⇒ | brianteeman |
| Category | Templates (site) | ⇒ |
@brianteeman sorry brian for whatever reason github decided my password was different and stopped sending me notices... fixed now.
Blank version is invisible on dark backgrounds due to dark outline. Should be lighter to be visible on both light and dark backgrounds.
The image on the right has increased brightness.
Images should also be optimized.