[#9966] - Vote button missing default styling in 3.5.1
- Closed
- 19 Apr 2016
- Medium
- Build: staging
- # 9966
- Diff
- N6REJ:votebutton
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
added btn-default to the "rate" button to provide default bootstrap styling in 3.5.1
Testing Instructions
create a article that has voting turned on.
inspect the "rate" button. You'll see that there is no default styling.
install the patch and you will see the styling added... and button will take on the default color style for
buttons.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
| Category | ⇒ | Plugins Templates (site) |
Is this meant for future Joomla versions in case a new Bootstrap version is bundled? Because .btn-default class doesn't exist in Bootstrap v2 currently included in Joomla.
This PR is wrong as it is using a non existent class. That why @andrepereiradasilva couldn't see any change.
Check the bootstrap docs :)
sorry my bad.. I'm so used to bs3 never dawned on me bs2 would change the name of that single button class when all the rest are the same LOL...
it might be nice to leave it as bs3 prep but I understand if you want to close it brian. .sorry @andrepereiradasilva
Sorry but closing this
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-19 08:24:18 |
| Closed_By | ⇒ | brianteeman |
i can't see any visual change in protostar after PR. But i can see the new css class.