? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
17 Apr 2016

Pull Request for New Issue.

Summary of Changes

Small PR for solving the following issue.

Isis system message close buttons are wrongly placed with causes when you close a message to closes all the messages.

This PR will make isis system messages working like the other templates.

Before patch

image

After patch

image

Testing Instructions

Very easy test. Just use the patchtester without github credentials.

  1. Apply any other patch.

    Check the two messages that appear in the patch tester.

    You only have one close button that close both messages.

  2. Apply this patch.

    Check the two messages that appear in the patch tester.

    You should have two close buttons, each close each message.

avatar andrepereiradasilva andrepereiradasilva - open - 17 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 17 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Apr 2016
Labels Added: ?
avatar richard67 richard67 - test_item - 17 Apr 2016 - Tested successfully
avatar richard67
richard67 - comment - 17 Apr 2016

I have tested this item :white_check_mark: successfully on a86f0a9


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9962.

avatar MATsxm MATsxm - test_item - 17 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 17 Apr 2016

I have tested this item :white_check_mark: successfully on a86f0a9


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9962.

avatar brianteeman brianteeman - change - 18 Apr 2016
Category Templates (admin)
avatar brianteeman brianteeman - change - 18 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 18 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9962.

avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 18 Apr 2016
Milestone Added:
avatar wilsonge wilsonge - close - 18 Apr 2016
avatar wilsonge wilsonge - merge - 18 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 18 Apr 2016
avatar wilsonge wilsonge - reference | 9126576 - 18 Apr 16
avatar wilsonge wilsonge - merge - 18 Apr 2016
avatar wilsonge wilsonge - change - 18 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-18 08:10:35
Closed_By wilsonge
avatar wilsonge wilsonge - close - 18 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2016
Labels Removed: ?
avatar wilsonge
wilsonge - comment - 18 Apr 2016

Merged - thanks :)

avatar andrepereiradasilva
andrepereiradasilva - comment - 18 Apr 2016

@richard67 @MATsxm thanks for testing!

avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 18 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment