I have tested this item successfully on 6751718

TEST OK

Entered a DUTCH TOS in the plugin as article, made association to UK version. When registering in the frontend on UK language I get the UK TOS.
(before patch i got a 404)

Please make Travis happy:

FOUND 4 ERROR(S) AND 1 WARNING(S) AFFECTING 3 LINE(S)

--------------------------------------------------------------------------------

  97 | WARNING | Inline control structures are discouraged

  98 | ERROR   | No space found after comma in function call

  98 | ERROR   | No space found after comma in function call

  98 | ERROR   | No space found after comma in function call

 101 | ERROR   | Expected "if (...)\n...{...}\n...else\n"; found "if (...)

     |         | ...{...}\n...else\n"

I.e. you should modify the PR to get:

            $db    = JFactory::getDbo();
            $query = $db->getQuery(true);
            $query->select('id, alias, catid, language')
                ->from('#__content')
                ->where('id = ' . $tosarticle);
            $db->setQuery($query);
            $article = $db->loadObject();

            if (JLanguageAssociations::isEnabled())
            {
                $tosassociated = JLanguageAssociations::getAssociations('com_content', '#__content', 'com_content.item', $tosarticle);
            }

            $current_lang = JFactory::getLanguage()->getTag();

            if ($current_lang != $article->language && array_key_exists($current_lang, $tosassociated))
            {
                $url = ContentHelperRoute::getArticleRoute($tosassociated[$current_lang]->id, $tosassociated[$current_lang]->catid);
            }
            else
            {
                $slug = $article->alias ? ($article->id . ':' . $article->alias) : $article->id;
                $url = ContentHelperRoute::getArticleRoute($slug, $article->catid);
            }

@mannybiker See mannybiker#1

This PR has received new commits.

CC: @mikeveeckmans

I am sorry for the errors. I am quite new to all these tools like github and php_codesniffer and the first time I really try to collaborate to a big project like Joomla. I have now configured php_codesniffer to avoid making again this kind of errors and raised a new commit with the code fix. Please forgive me and thanks for your help and suggestions.

I have tested this item successfully on 0befa18

Great patch!

I have tested this item successfully on 0befa18

Thanks

This is a small patch but I am too happy and honoured to be appreciated by Guru like you!

RTC. Can go in 3.5.2.

I don't agree with the statement "can go into 3.5.x", I think this is a new feature and in fact it change how the system works. After the patch you get a different article when there was an associated article before.

It does not break anything as it is totally BC, @rdeutz . It just adds the possibility to have a TOS per language with a very simple check in code. No use to wait for 3.6.0 to get this in.

As I said, if you have an associated article for the chosen TOC before you will get this article after the patch and this is a change how the system behaves.

I've a Notice & Warning with this patch, I've enabled TOS as the only mandatory field, mono-lingual site.
Notice: Undefined variable: tosassociated in plugins ...\user\profile\fields\tos.php on line 104
Warning: array_key_exists() expects parameter 2 to be array, null given in plugins ...\user\profile\fields\tos.php on line 104

I've inserted "$tosassociated = array();" couple of lines above as a quick fix.

@jsubri Thanks for reporting.
I have issued a PR #10366