? Success

User tests: Successful: Unsuccessful:

avatar wojsmol
wojsmol
15 Apr 2016

Pull Request for #9899 (comment)

Summary of Changes

Add 'Search' & 'Clear text' buttons to compact list of tagged items view

Testing Instructions

  • Install the current staging with testing sample data.
  • Install the patch tester component.
  • Add Yellow tag to some articles.
  • Go to Front End and click on the link Compact tagged from All Front End Views menu .
  • Note that the next search does not have a buttons 'Search' & 'Clear text'
  • Go to Back End apply the patch.
  • Go to the Front End, refresh the page and note that the button 'Search' & 'Clear text' appeared.
  • Check whether the buttons work.
avatar wojsmol wojsmol - open - 15 Apr 2016
avatar wojsmol wojsmol - change - 15 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2016
Labels Added: ?
avatar richard67 richard67 - test_item - 15 Apr 2016 - Tested successfully
avatar richard67
richard67 - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on fb1e5a7

The test step "Add Yellow tag to some articles." is not really necessary because there are already 2 tagged articles.

But if you want to add some tags to have more, the step should happen before step "Go to Front End and click on the link Compact tagged from All Front End Views menu".

Otherwise some pedant may say you are not comparing the same scenario before and after patch, so maybe adding this yellow tag did the fix and not the patch.

I know, is pedantic, but for should be kept in mind: Always compare same thing before and after patch to really proof the patch helps and not the test step in between.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9940.

avatar wojsmol
wojsmol - comment - 15 Apr 2016

@richard67 testing instructions updated

avatar MATsxm MATsxm - test_item - 15 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on fb1e5a7

#9940 works great here - Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9940.

avatar brianteeman brianteeman - change - 16 Apr 2016
Category Accessibility
avatar brianteeman brianteeman - change - 16 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 16 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9940.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 16 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - change - 16 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-16 07:48:07
Closed_By rdeutz
avatar rdeutz rdeutz - close - 16 Apr 2016
avatar rdeutz rdeutz - merge - 16 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 16 Apr 2016
avatar rdeutz rdeutz - reference | b9189fd - 16 Apr 16
avatar rdeutz rdeutz - merge - 16 Apr 2016
avatar rdeutz rdeutz - close - 16 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 16 Apr 2016
Labels Removed: ?
avatar wojsmol wojsmol - head_ref_deleted - 16 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment