[#9939] - Smart Search "Warning: mb_strpos(): Empty delimiter"
- Fixed in Code Base
- 19 Apr 2016
- Medium
- Build: staging
- # 9939
- Diff
- chrisdavenport:patch-3
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR avoids the mb_strpos empty delimiter warning that can occur when "Allow Empty Search" is used and no search term is entered.
Summary of Changes
The default Smart Search layout does not check for an empty search term before calling JString::strpos, which ultimately leads to a warning being thrown in mb_strpos.
Testing Instructions
- Make sure you have Smart Search set up and working with some content indexed.
- Add a menu item to point to the Smart Search results page. Set "Allow Empty Search" to "Yes" in the menu item (setting this at global level doesn't produce the error (not sure why)).
- Set "Error Reporting" to "Development" in Global Configuration.
- Use your menu item to go to the search page.
- Use Advanced Search to select something from a dropdown. For example, choose "Uncategorised" from the "Category" dropdown.
- Without entering any search terms, click the Search button. You should see an error message like "Warning: mb_strpos(): Empty delimiter in /var/www/temp/joomla-mb-strpos/libraries/vendor/joomla/string/src/phputf8/mbstring/core.php on line 41"
- Apply this PR and try searching again. The warning message should no longer appear.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
@chrisdavenport Do you have a test system with an old mysql database not supporting utf8mb4 yet, and a bit mood and time for testing? I urgently need some tester with such emvironment for my PR 9847 (not wanna use the hashtag here so it not gets linked because is unrelated to this here). Or do you know someone who could help with that?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9939.
@richard67 how to know if a database not support utf8mb4?
@franz-wohlkoenig Either try in phpMyAdmin to set the database default collation to "utf8mb4_general_ci" - if it works, your combination of database server and client api used by phpMyAdmin supports utf8mb4, and if this does not work, it doesn't support it. And hope the client API used by phpMyAdmin is the same as the one used by the Joomla (which should be the case on a dedicated server or a local testing environment but may not be the case on shared hosting).
Or check in backend in system information your mysql database server version and which client api is used and its version.
If mysql server version is lower than 5.5.3, or mysqlnd client API with version lower than 5.0.9 is used, or other mysql client API with version lower than 5.5.3 is used, then there is no utf8mb4 support, esle there is.
@franz-wohlkoenig P.S.: If further questions, lets discuss them in my PR 9847 in order not to hijack this here. Just pinged Chris here in his PR because I hoped he could help.
@richard67 Sorry, I don't have anything old enough to not support utf8mb4.
No problem .. just wish me good luck someone will test then.
That I can do: Good luck. :-)
| Category | ⇒ | Search |
I have tested this item 
successfully on 4abdece
Warning disappears. Suppose global level has no effect bc you cannot use "Use Global" with this parameter (bug?).
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9939.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-19 11:31:26 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
I have tested this item
successfully on 4abdece
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9939.